From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756139Ab0IPUXG (ORCPT ); Thu, 16 Sep 2010 16:23:06 -0400 Received: from smtp102.sbc.mail.ne1.yahoo.com ([98.138.84.213]:27587 "HELO smtp102.sbc.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752309Ab0IPUXE (ORCPT ); Thu, 16 Sep 2010 16:23:04 -0400 X-Yahoo-SMTP: fzDSGlOswBCWnIOrNw7KwwK1j9PqyNbe5PtLKiS4dDU.UNl_t6bdEZu9tTLW X-YMail-OSG: P8gpFJgVM1kWkVQiv0XrtSje0x_MtMcDfy6fybmoqyQouuA j1CKE4UylIN3Cas2j2RPQh2c_CHLjDUcXvyHrE5XwfMAGWi_W3weQyv4L5DH xYoQHbZDdxE5rdQl0jxF66f22T3yQ86JTmDHQYOC.jChO3.hhcPeFzFb38rx rZyIc38afw89lRE1Wnql38MgZ1dalW9jUSa8ZENyzIb3McLOuKVFWR8QIm.3 Qs4675gMzmiuYyloypAGJW4nzyG5J8J6zKbAsJTfShhjOuVEq2rFaVgLSVM3 K86.qJ9SvXNG7ReitbJ5TiPikdiOblJfTTgzJUC1t6lswSI1NP0s- X-Yahoo-Newman-Property: ymail-3 From: "Nicholas A. Bellinger" To: linux-scsi , linux-kernel , Mike Christie , FUJITA Tomonori , Hannes Reinecke Cc: James Bottomley , Konrad Rzeszutek Wilk , Douglas Gilbert , Joe Eykholt , Boaz Harrosh , Nicholas Bellinger Subject: [PATCH] lio-target: Enable crc32c_x86_offload=1 by default Date: Thu, 16 Sep 2010 13:22:59 -0700 Message-Id: <1284668579-10260-1-git-send-email-nab@linux-iscsi.org> X-Mailer: git-send-email 1.5.6.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Bellinger Greetings all, This patch enables the default usage of the SSE v4.2 CRC32C instruction for iSCSI target HeaderDigests and DataDigests offload using libcrypto and the crc32c-intel.ko module on Nehalem systems. This was originally disabled by default in commit 047eeb75ee8f0 due to some issues with HeaderDigests=CRC32C that where encountered with the Open-iSCSI initiator shipping with RHEL 6 B1. This has now been identified as initiator side breakage, so we go ahead and enable crc32c_x86_offload=1 by default when available. Many thanks again to Mike Christie for verifying the Open-iSCSI side issue! Signed-off-by: Nicholas A. Bellinger --- drivers/target/lio-target/iscsi_target_core.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/target/lio-target/iscsi_target_core.h b/drivers/target/lio-target/iscsi_target_core.h index de962c8..882bd52 100644 --- a/drivers/target/lio-target/iscsi_target_core.h +++ b/drivers/target/lio-target/iscsi_target_core.h @@ -84,7 +84,7 @@ /* Disabled by default in production mode w/ explict ACLs */ #define TA_PROD_MODE_WRITE_PROTECT 0 /* Disabled by default for the moment for testing... */ -#define TA_CRC32C_X86_OFFLOAD 0 +#define TA_CRC32C_X86_OFFLOAD 1 #define TA_CACHE_CORE_NPS 0 /* struct iscsi_data_count->type */ -- 1.5.6.5