From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756983Ab0IPWgf (ORCPT ); Thu, 16 Sep 2010 18:36:35 -0400 Received: from smtp103.sbc.mail.ac4.yahoo.com ([76.13.13.242]:28477 "HELO smtp103.sbc.mail.ac4.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756512Ab0IPWgc (ORCPT ); Thu, 16 Sep 2010 18:36:32 -0400 X-Yahoo-SMTP: fzDSGlOswBCWnIOrNw7KwwK1j9PqyNbe5PtLKiS4dDU.UNl_t6bdEZu9tTLW X-YMail-OSG: Z5iGeREVM1nCEdYC0oU2uVrjUyf_AO5SykvWz6r6yfzkYGS 2bolE5lIZhBVKQDyzxQmeE5j697zb4YZKshAoXJzjqOx_0r1_TTGQHQpo0S6 OPdRhTB22SroUrXp4pacIpIIosE7cC1spMAd2zi_HszrHX1fQH8464IOktaq cTlqS6y.irhHv9iy4xIPzMZjU.PDjq99aJzCErxoDgRvUY6dBO09Aig8L04Q b8ViEh3KfGz0i.FaFoD5vWNOMkKoJ4mBWci3ExQqxx2ivf78hOwrKO14.lJC k7p3DrDVJKjAjZk5tcdZWux6EdFMpPDw69nmYic_jZ0lZQnGTIA-- X-Yahoo-Newman-Property: ymail-3 From: "Nicholas A. Bellinger" To: linux-scsi , linux-kernel , Vasu Dev , Tim Chen , Andi Kleen , Matthew Wilcox , James Bottomley , Mike Christie Cc: James Smart , Andrew Vasquez , FUJITA Tomonori , Hannes Reinecke , Joe Eykholt , Christoph Hellwig , Nicholas Bellinger Subject: [PATCH 8/8] libfc: Remove host_lock unlock() + lock() from fc_queuecommand() Date: Thu, 16 Sep 2010 15:36:27 -0700 Message-Id: <1284676587-10892-1-git-send-email-nab@linux-iscsi.org> X-Mailer: git-send-email 1.5.6.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Bellinger This patch removes the now legacy host_lock unlock() + lock() optimization fc_fcp.c:fc_queuecommand() Signed-off-by: Nicholas A. Bellinger --- drivers/scsi/libfc/fc_fcp.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index c797f6b..140cd94 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c @@ -1751,8 +1751,7 @@ static inline int fc_fcp_lport_queue_ready(struct fc_lport *lport) * @cmd: The scsi_cmnd to be executed * @done: The callback function to be called when the scsi_cmnd is complete * - * This is the i/o strategy routine, called by the SCSI layer. This routine - * is called with the host_lock held. + * This is the i/o strategy routine, called by the SCSI layer. */ int fc_queuecommand(struct scsi_cmnd *sc_cmd, void (*done)(struct scsi_cmnd *)) { @@ -1772,7 +1771,6 @@ int fc_queuecommand(struct scsi_cmnd *sc_cmd, void (*done)(struct scsi_cmnd *)) done(sc_cmd); return 0; } - spin_unlock_irq(lport->host->host_lock); if (!*(struct fc_remote_port **)rport->dd_data) { /* @@ -1849,7 +1847,6 @@ int fc_queuecommand(struct scsi_cmnd *sc_cmd, void (*done)(struct scsi_cmnd *)) rc = SCSI_MLQUEUE_HOST_BUSY; } out: - spin_lock_irq(lport->host->host_lock); return rc; } EXPORT_SYMBOL(fc_queuecommand); -- 1.7.2.3