From: Nikunj Kela <quic_nkela@quicinc.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Sudeep Holla <sudeep.holla@arm.com>
Cc: <cristian.marussi@arm.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional parameter
Date: Tue, 18 Apr 2023 10:07:17 -0700 [thread overview]
Message-ID: <12846dc1-38b6-892a-3189-25db866fa38e@quicinc.com> (raw)
In-Reply-To: <40e91346-19d7-c0b4-7fcc-d5a2081fe8dd@gmail.com>
On 4/18/2023 9:33 AM, Florian Fainelli wrote:
> On 4/18/23 07:20, Nikunj Kela wrote:
>>
>> On 4/18/2023 2:58 AM, Sudeep Holla wrote:
>>> On Mon, Apr 17, 2023 at 11:01:13AM -0700, Florian Fainelli wrote:
>>>> On 4/17/23 10:44, Nikunj Kela wrote:
>>>>> This patch add support for passing shmem channel address as parameter
>>>>> in smc/hvc call. This patch is useful when multiple scmi instances
>>>>> are
>>>>> using same smc-id and firmware needs to distiguish among the
>>>>> instances.
>>>> Typo: distinguish.
>>>>
>>>> It really would have been a lot clearer and made a whole lot more
>>>> sense to
>>>> encode a VM ID/channel number within some of the SMCCC parameters,
>>>> possibly
>>>> as part of the function ID itself.
>>>>
>>> Yes I was about to suggest this but then remembered one main reason
>>> I have
>>> been given in the past against that:
>>> If the system launches high number of VMs then that means loads of FID
>>> needs to be reserved for SCMI and the hypervisor needs to support it.
>>> Basically it is not scalable which I agree but not sure if such large
>>> number of VMs are used in reality with SCMI. But I agree with the
>>> technical
>>> reasoning.
>>>
>>> The other reason why I preferred the shmem address itself instead of
>>> some
>>> custom VM ID/channel number is that it can easily becomes vendor
>>> specific
>>> for no real good reason and then we need to add support for each such
>>> different parameters. Nikunj suggested getting them from DT which I
>>> really
>>> don't like if the sole reason is just to identify the channel. We don't
>>> have standard SCMI SMC/HVC but allowing such deviations with params
>>> from
>>> DT will just explode with various combinations for silly/no reason.
>>>
>> Would you be ok to pass the smc/hvc parameters via kernel parameters
>> in commandline? If so, I can implement that. I just wanted to keep
>> everything in one place hence suggested using DTB node.
>
> Command line arguments seem a bit unnecessary here and it would force
> you to invent a scheme to control per SCMI device/instance parameters.
>
Agreed!
>>
>>> [...]
>>>
>>>>> @@ -137,6 +144,8 @@ static int smc_chan_setup(struct
>>>>> scmi_chan_info *cinfo, struct device *dev,
>>>>> if (ret < 0)
>>>>> return ret;
>>>>> + if (of_device_is_compatible(dev->of_node, "arm,scmi-smc-param"))
>>>>> + scmi_info->param = res.start;
>>>> There is not even a check that this is going to be part of the
>>>> kernel's view
>>>> of memory, that seems a bit brittle and possibly a security hole,
>>>> too. Your
>>>> hypervisor presumably needs to have carved out some amount of
>>>> memory in
>>>> order for the messages to be written to/read from, and so would the VM
>>>> kernel, so eventually we should have a 'reserved-memory' entry of
>>>> some sort,
>>>> no?
>>>>
>>> Not disagreeing here. Just checking if my understanding is correct
>>> or not.
>>> IIUC, we need reserved-memory if it is part of the memory presented
>>> to the
>>> OS right ? You don't need that if it is dedicated memory like part
>>> of SRAM
>>> or something similar.
>> We are not using reserved-memory node. Instead using sram-mmio to
>> carve out shmem for scmi instances.
>
> OK, that works too.
>
>>>>> /*
>>>>> * If there is an interrupt named "a2p", then the service and
>>>>> * completion of a message is signaled by an interrupt
>>>>> rather than by
>>>>> @@ -156,6 +165,7 @@ static int smc_chan_setup(struct
>>>>> scmi_chan_info *cinfo, struct device *dev,
>>>>> }
>>>>> scmi_info->func_id = func_id;
>>>>> + scmi_info->is_smc64 = ARM_SMCCC_IS_64(func_id);
>>>>> scmi_info->cinfo = cinfo;
>>>>> smc_channel_lock_init(scmi_info);
>>>>> cinfo->transport_info = scmi_info;
>>>>> @@ -188,7 +198,20 @@ static int smc_send_message(struct
>>>>> scmi_chan_info *cinfo,
>>>>> shmem_tx_prepare(scmi_info->shmem, xfer, cinfo);
>>>>> - arm_smccc_1_1_invoke(scmi_info->func_id, 0, 0, 0, 0, 0, 0, 0,
>>>>> &res);
>>>>> +#ifdef CONFIG_ARM64
>>>>> + /*
>>>>> + * if SMC32 convention is used, pass 64 bit address in
>>>>> + * two parameters
>>>>> + */
>>>>> + if (!scmi_info->is_smc64)
>>>> There is no need for scmi_info to store is_smc64, just check the
>>>> func_id
>>>> here and declare is_smc64 as a local variable to the function.
>>>>
>>> +1
>> ACK!
>>>> Also, another way to approach this would be to encode the
>>>> parameters region
>>>> in 4KB units such that event on a 32-bit system with LPAE you are
>>>> guaranteed
>>>> to fit the region into a 32-bit unsigned long. AFAIR virtualization
>>>> and LPAE
>>>> are indistinguishable on real CPUs?
>>>>
>>> Agree with the idea. But can a single 4kB be used for multiple shmem
>>> across
>>> VMs ? IIUC the hypervisor can deal with that, so I prefer it if it
>>> is possible
>>> practically.
>> We have multiple VMs and each VM has multiple instances. We will have
>> quite a few domains and I am not sure if single page will suffice.
>
> I did not make myself clear enough, you can encode an offset into the
> shared memory area, and however big that shared memory area will be,
> that offset can be in a 4KB size. So for instance if you have your
> MMIO SRAM at 0x8000_0000, the first VM can use 0x8000_0ffff, the
> second VM can use 0x8000_1000 to 0x8000_1fff and so on and so forth.
>
> Even if you need more than 4KB per VM, you can put that information
> into the two additional parameters you pass through the SMC/HVC call.
Okay. I will float another version, first parameter of smc/hvc call will
be pfn and second the offset!
next prev parent reply other threads:[~2023-04-18 17:08 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-09 18:19 [PATCH 0/2] Allow parameter in smc/hvc calls Nikunj Kela
2023-04-09 18:19 ` [PATCH 1/2] dt-bindings: firmware: arm,scmi: support parameter passing in smc/hvc Nikunj Kela
2023-04-10 17:20 ` Krzysztof Kozlowski
2023-04-10 17:33 ` Nikunj Kela
2023-04-11 17:17 ` Krzysztof Kozlowski
2023-04-09 18:19 ` [PATCH 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional parameters Nikunj Kela
2023-04-09 22:22 ` kernel test robot
2023-04-10 18:20 ` [PATCH v2 0/2] Allow parameter in smc/hvc calls Nikunj Kela
2023-04-10 18:20 ` [PATCH v2 1/2] dt-bindings: firmware: arm,scmi: support parameter passing in smc/hvc Nikunj Kela
2023-04-11 12:54 ` Sudeep Holla
2023-04-11 14:46 ` Nikunj Kela
2023-04-11 17:18 ` Krzysztof Kozlowski
2023-04-11 17:25 ` Nikunj Kela
2023-04-10 18:20 ` [PATCH v2 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional parameters Nikunj Kela
2023-04-11 13:01 ` [PATCH v2 0/2] Allow parameter in smc/hvc calls Sudeep Holla
2023-04-11 14:42 ` Nikunj Kela
2023-04-12 8:37 ` Sudeep Holla
2023-04-12 14:54 ` Nikunj Kela
2023-04-17 17:43 ` [PATCH v3 " Nikunj Kela
2023-04-17 17:44 ` [PATCH v3 1/2] dt-bindings: firmware: arm,scmi: support for parameter in smc/hvc call Nikunj Kela
2023-04-17 17:44 ` [PATCH v3 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional parameter Nikunj Kela
2023-04-17 18:01 ` Florian Fainelli
2023-04-17 18:17 ` Nikunj Kela
2023-04-18 9:58 ` Sudeep Holla
2023-04-18 14:20 ` Nikunj Kela
2023-04-18 16:33 ` Florian Fainelli
2023-04-18 17:07 ` Nikunj Kela [this message]
2023-04-18 18:56 ` [PATCH v4 0/2] Allow parameter in smc/hvc calls Nikunj Kela
2023-04-18 18:56 ` [PATCH v4 1/2] dt-bindings: firmware: arm,scmi: support for parameter in smc/hvc call Nikunj Kela
2023-04-25 16:50 ` Rob Herring
2023-04-18 18:56 ` [PATCH v4 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional parameters Nikunj Kela
2023-05-01 14:39 ` Nikunj Kela
2023-05-02 10:46 ` Sudeep Holla
2023-05-02 14:41 ` Nikunj Kela
2023-04-25 14:01 ` [PATCH v4 0/2] Allow parameter in smc/hvc calls Nikunj Kela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12846dc1-38b6-892a-3189-25db866fa38e@quicinc.com \
--to=quic_nkela@quicinc.com \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®