From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756145Ab0IQSXE (ORCPT ); Fri, 17 Sep 2010 14:23:04 -0400 Received: from smtp101.sbc.mail.ac4.yahoo.com ([76.13.13.240]:23803 "HELO smtp101.sbc.mail.ac4.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755911Ab0IQSXB (ORCPT ); Fri, 17 Sep 2010 14:23:01 -0400 X-Yahoo-SMTP: fzDSGlOswBCWnIOrNw7KwwK1j9PqyNbe5PtLKiS4dDU.UNl_t6bdEZu9tTLW X-YMail-OSG: wlEiyMwVM1lZKMeoXwhQGFOqhgOLv2zel.PJRCPqBBjTxWC KQu9cCahxlZQmbrO4XemG2f2yUwJrNMMq68Owo5Lx05dcc_j91nNFuic9.Eo UAboPm4RAO2Ih8yjDhjulj3pp92rIJaRvZYW.t4qsAwtMxe21XE7GIUXCj0t FPVUN.tKrsGfDDFKEeyxp07ZuizykcCsYjDXO.aa6PNTnHdD2rzIzn_o3HCD zSz9KaUs9c_a._a4VhK4Y7ewINWPBpact7JgMFYCHOoP651uzvKGgoZaOwUj L56j_162URWiR4QQXnjt5x7SfbCDnW1SGRkDh7FRIOtpJwerEFA-- X-Yahoo-Newman-Property: ymail-3 From: "Nicholas A. Bellinger" To: linux-scsi , linux-kernel , Vasu Dev , Tim Chen , Andi Kleen , Matthew Wilcox , James Bottomley , Mike Christie Cc: James Smart , Andrew Vasquez , FUJITA Tomonori , Hannes Reinecke , Joe Eykholt , Christoph Hellwig , Nicholas Bellinger Subject: [PATCH v2 08/11] qla4xxx: Remove host_lock unlock() + lock() from qla4xxx_queuecommand() Date: Fri, 17 Sep 2010 11:22:55 -0700 Message-Id: <1284747775-20995-1-git-send-email-nab@linux-iscsi.org> X-Mailer: git-send-email 1.5.6.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Bellinger This patch removes the now legacy host_lock unlock() + lock() optimization from ql4_os.c:qla4xxx_queuecommand() Signed-off-by: Nicholas A. Bellinger --- drivers/scsi/qla4xxx/ql4_os.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 370d40f..cfbe8b5 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -511,26 +511,20 @@ static int qla4xxx_queuecommand(struct scsi_cmnd *cmd, test_bit(DPC_RESET_HA_FW_CONTEXT, &ha->dpc_flags)) goto qc_host_busy; - spin_unlock_irq(ha->host->host_lock); - srb = qla4xxx_get_new_srb(ha, ddb_entry, cmd, done); if (!srb) - goto qc_host_busy_lock; + goto qc_host_busy; rval = qla4xxx_send_command_to_isp(ha, srb); if (rval != QLA_SUCCESS) goto qc_host_busy_free_sp; - spin_lock_irq(ha->host->host_lock); return 0; qc_host_busy_free_sp: qla4xxx_srb_free_dma(ha, srb); mempool_free(srb, ha->srb_mempool); -qc_host_busy_lock: - spin_lock_irq(ha->host->host_lock); - qc_host_busy: return SCSI_MLQUEUE_HOST_BUSY; -- 1.7.2.3