From: Guenter Roeck <linux@roeck-us.net>
To: Wolfram Sang <wsa@kernel.org>,
Lakshmi Yadlapati <lakshmiy@us.ibm.com>,
sumit.semwal@linaro.org, christian.koenig@amd.com,
jdelvare@suse.com, joel@jms.id.au, andrew@aj.id.au,
eajames@linux.ibm.com, ninad@linux.ibm.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-hwmon@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1 0/2] [PATCH] hwmon: (pmbus/max31785) Add minimum delay between bus accesses
Date: Tue, 10 Oct 2023 06:45:15 -0700 [thread overview]
Message-ID: <1284830f-025e-4e25-8ed0-50a6cc00d223@roeck-us.net> (raw)
In-Reply-To: <ZSUaDIfWmEn5edrE@shikoro>
On Tue, Oct 10, 2023 at 11:31:56AM +0200, Wolfram Sang wrote:
> Hi,
>
> thanks for this series!
>
> > Reference to Andrew's previous proposal:
> > https://lore.kernel.org/all/20200914122811.3295678-1-andrew@aj.id.au/
>
> I do totally agree with Guenter's comment[1], though. This just affects
> a few drivers and this patch is way too intrusive for the I2C core. The
> later suggested prepare_device() callback[2] sounds better to me. I
> still haven't fully understood why this all cannot be handled in the
> driver's probe. Could someone give me a small summary about that?
>
Lots of PMBus devices have the same problem, we have always handled
it in PMBus drivers by implementing local wait code, and your references
point that out. What other summary are you looking for ?
On a side note, if anyone plans to implement the prepare_device() callback,
please make sure that it covers all requirements. It would be unfortunate
if such a callback was implemented if that would still require per-driver
code (besides the callback).
Thanks,
Guenter
next prev parent reply other threads:[~2023-10-10 13:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 21:14 Lakshmi Yadlapati
2023-10-09 21:14 ` [PATCH v1 1/2] i2c: smbus: Allow throttling of transfers to client devices Lakshmi Yadlapati
2023-10-12 14:18 ` Jean Delvare
2023-10-12 15:08 ` Jani Nikula
2023-10-09 21:14 ` [PATCH v1 2/2] hwmon: (pmbus/max31785) Add minimum delay between bus accesses Lakshmi Yadlapati
2023-10-09 22:10 ` [PATCH v1 0/2] [PATCH] " Lakshmi Yadlapati
2023-10-10 9:31 ` Wolfram Sang
2023-10-10 13:45 ` Guenter Roeck [this message]
2023-10-10 18:58 ` Wolfram Sang
2023-10-10 22:59 ` Guenter Roeck
2023-10-11 3:54 ` Andrew Jeffery
2023-10-11 16:14 ` Lakshmi Yadlapati
2023-10-11 16:27 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284830f-025e-4e25-8ed0-50a6cc00d223@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@aj.id.au \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=lakshmiy@us.ibm.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=sumit.semwal@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®