mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: nhorman@tuxdriver.com, eugene@redhat.com
Cc: linux-kernel@vger.kernel.org, oleg@tv-sign.ru
Subject: [RFC PATCH] proc: making "limits" world readable
Date: Tue, 21 Sep 2010 11:10:55 +0200	[thread overview]
Message-ID: <1285060255-15784-1-git-send-email-jolsa@redhat.com> (raw)

hi,

I'd like to have the /proc/<pid>/limits file world readable,
but I'm not sure this could cause some security issue.. thoughts?

The "limit" file was as a debug feature by following commit:
- proc: export a processes resource limits via /proc/pid
  commit d85f50d5e1aa99ab082035f94265847521819e58
  Author: Neil Horman <nhorman@tuxdriver.com>


thanks for any ideas,
jirka
---
 fs/proc/base.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/proc/base.c b/fs/proc/base.c
index a1c43e7..8e4adda 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -2675,7 +2675,7 @@ static const struct pid_entry tgid_base_stuff[] = {
 	INF("auxv",       S_IRUSR, proc_pid_auxv),
 	ONE("status",     S_IRUGO, proc_pid_status),
 	ONE("personality", S_IRUSR, proc_pid_personality),
-	INF("limits",	  S_IRUSR, proc_pid_limits),
+	INF("limits",	  S_IRUGO, proc_pid_limits),
 #ifdef CONFIG_SCHED_DEBUG
 	REG("sched",      S_IRUGO|S_IWUSR, proc_pid_sched_operations),
 #endif
@@ -3011,7 +3011,7 @@ static const struct pid_entry tid_base_stuff[] = {
 	INF("auxv",      S_IRUSR, proc_pid_auxv),
 	ONE("status",    S_IRUGO, proc_pid_status),
 	ONE("personality", S_IRUSR, proc_pid_personality),
-	INF("limits",	 S_IRUSR, proc_pid_limits),
+	INF("limits",	 S_IRUGO, proc_pid_limits),
 #ifdef CONFIG_SCHED_DEBUG
 	REG("sched",     S_IRUGO|S_IWUSR, proc_pid_sched_operations),
 #endif
-- 
1.7.1


             reply	other threads:[~2010-09-21  9:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21  9:10 Jiri Olsa [this message]
2010-09-23 21:56 ` Andrew Morton
2010-09-24 10:55   ` Jiri Olsa
2010-09-24 16:20     ` Neil Horman
2010-09-24 18:32       ` Andrew Morton
2010-09-27  8:49         ` [PATCHv2] " Jiri Olsa
2010-09-27 10:41           ` Neil Horman
2010-09-27  7:23       ` [RFC PATCH] " Eugene Teo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285060255-15784-1-git-send-email-jolsa@redhat.com \
    --to=jolsa@redhat.com \
    --cc=eugene@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=oleg@tv-sign.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®