From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752471Ab0IULm1 (ORCPT ); Tue, 21 Sep 2010 07:42:27 -0400 Received: from mail-fx0-f46.google.com ([209.85.161.46]:53901 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767Ab0IULm0 (ORCPT ); Tue, 21 Sep 2010 07:42:26 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=wudiw1p8y/b224hiz+VmgQgTZYzfk93Wuv33sphzQY6N8RtxAZWxge7ibGmRTUlhm9 jQrZ7zQeaMzwYZUerPYFeHpMrEuU0gLdkHYa6PP4eAMmqHyUTukFJexJPrxpczVJjJ3/ w0Y4EdCj2ZdSW49J6/u7OJxbPaIUK8WSOW6SQ= Subject: Re: [REGRESSION] cdrom drive doesn't detect removal From: Maxim Levitsky To: Kay Sievers Cc: Henrique de Moraes Holschuh , Tejun Heo , linux-kernel , Jens Axboe In-Reply-To: References: <1284284969.2928.18.camel@maxim-laptop> <1284427621.4127.7.camel@maxim-laptop> <4C8F2699.3020509@kernel.org> <1284507516.4963.2.camel@maxim-laptop> <1284511071.3551.1.camel@maxim-laptop> <20100915132731.GA20558@khazad-dum.debian.net> <1284589207.4672.3.camel@maxim-laptop> Content-Type: text/plain; charset="UTF-8" Date: Tue, 21 Sep 2010 13:42:18 +0200 Message-ID: <1285069338.3124.4.camel@maxim-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2010-09-16 at 08:51 +0200, Kay Sievers wrote: > On Thu, Sep 16, 2010 at 00:20, Maxim Levitsky wrote: > > So it makes the sense. > > It turns out that hal is still running on ubuntu systems, and yes, it > > still polls the drives, and yes I disabled that feature.... > > So restoring that polling feature indeed fixes that problem for now. > > Yet, why without that commit detection did work? > > Really, I have no idea how this can happen. You could only find out > with blocktrace, if something else is trying to open the device. The > state change in the drive should not be able to get known to the host > unless something is causing i/o with open(). > > Kay Due to some unexplained laziness, I didn't put a printk to cdrom_open to figure out if drive is polled or not without hal. Today I finally found why kgdb didn't work (it was conflict with nmi watchdog), and just for fun I have put a breakpoint to cdrom_open. Well udisks *does* poll the drive, every few seconds, and therefore this is a regression. I will soon look at udisk source to see how it polls the drive. (Maybe it uses exclusive open and hal doesn't or something like that.) Best regards, Maxim Levitsky