From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Gregory Haskins <ghaskins@novell.com>
Subject: Re: [PATCH 3/4] tracing/sched: Add sched_rt_push and sched_rt_pull tracepoints
Date: Tue, 21 Sep 2010 09:36:27 -0400 [thread overview]
Message-ID: <1285076187.23122.1809.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1285072416.23122.1723.camel@gandalf.stny.rr.com>
On Tue, 2010-09-21 at 08:33 -0400, Steven Rostedt wrote:
> > Why doesn't the migration tracepoint cover this? It shows you the task,
> > the prio, the old and new cpu. If the migration is logged from the old
> > cpu, its a push, if its logged from the new its a pull, no?
>
> For some reason it did not help me enough in my analysis. I'll go back
> and see why.
>
> I originally had these tracepoints at the front of the series, and
> realized they may be a little controversial, thus I moved them to the
> end.
OK, I went back and looked, and I think you are right. I can determine
this from the migration tracepoint. I think I was just being lazy and
wanted to have the direction obvious to me :-) I can easily do that by
adding a plugin.
Anyway, I'll remove this patch and rename the sched_rt_setprio
tracepoint to sched_pi_setprio. Would that be OK with you?
Thanks,
-- Steve
next prev parent reply other threads:[~2010-09-21 13:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 2:40 [PATCH 0/4] [GIT PULL] sched: Migrate higher priority tasks less Steven Rostedt
2010-09-21 2:40 ` [PATCH 1/4] sched: Try not to migrate higher priority RT tasks Steven Rostedt
2010-09-21 14:14 ` [tip:sched/core] " tip-bot for Steven Rostedt
2010-09-21 2:40 ` [PATCH 2/4] sched: Give CPU bound RT tasks preference Steven Rostedt
2010-09-21 14:14 ` [tip:sched/core] " tip-bot for Steven Rostedt
2010-09-21 2:40 ` [PATCH 3/4] tracing/sched: Add sched_rt_push and sched_rt_pull tracepoints Steven Rostedt
2010-09-21 8:46 ` Peter Zijlstra
2010-09-21 12:33 ` Steven Rostedt
2010-09-21 13:36 ` Steven Rostedt [this message]
2010-09-21 19:26 ` Frank Rowand
2010-09-21 19:55 ` Frank Rowand
2010-09-21 2:40 ` [PATCH 4/4] tracing/sched: Add sched_rt_setprio tracepoint Steven Rostedt
2010-09-21 11:14 ` Peter Zijlstra
2010-09-21 12:35 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285076187.23122.1809.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=ghaskins@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®