From: James Bottomley <James.Bottomley@suse.de>
To: Greg KH <greg@kroah.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
Kay Sievers <kay.sievers@vrfy.org>,
Andrew Morton <akpm@linux-foundation.org>,
Vasiliy Kulikov <segooon@gmail.com>,
kernel-janitors@vger.kernel.org, Tejun Heo <tj@kernel.org>,
Jiri Slaby <jirislaby@gmail.com>,
linux-kernel@vger.kernel.org, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH 04/14] memstick: core: fix device_register() error handling
Date: Wed, 22 Sep 2010 11:23:57 -0500 [thread overview]
Message-ID: <1285172637.2993.195.camel@mulgrave.site> (raw)
In-Reply-To: <20100922162006.GA27853@kroah.com>
On Wed, 2010-09-22 at 09:20 -0700, Greg KH wrote:
> > What other email? ... neither you nor Kay replied after either Boaz's
> > patch or the corrected one were posted.
>
> See my other email a minute ago in response to this thread.
Can we start again? You've been replying to a patch to do a
put_device() in device_register() which everyone agrees looks wrong.
The proposal to fix all of this is to free the kobject name and NULL it
out in device_add(). That fixes all the places you and kay broke when
you added the variable length name stuff.
James
next prev parent reply other threads:[~2010-09-22 16:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-19 12:54 Vasiliy Kulikov
2010-09-21 22:20 ` Andrew Morton
2010-09-21 22:49 ` Greg KH
2010-09-22 8:53 ` Kay Sievers
2010-09-22 10:02 ` Boaz Harrosh
2010-09-22 15:47 ` Greg KH
2010-09-22 15:56 ` James Bottomley
2010-09-22 16:20 ` Greg KH
2010-09-22 16:23 ` James Bottomley [this message]
2010-09-22 15:50 ` Greg KH
2010-09-23 12:10 ` Vasiliy Kulikov
2010-09-22 9:58 ` Boaz Harrosh
2010-09-22 15:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285172637.2993.195.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=error27@gmail.com \
--cc=greg@kroah.com \
--cc=jirislaby@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®