From: Joe Perches <joe@perches.com>
To: David Howells <dhowells@redhat.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: checkpatch problem
Date: Thu, 23 Sep 2010 11:27:34 -0700 [thread overview]
Message-ID: <1285266454.31572.29.camel@Joe-Laptop> (raw)
In-Reply-To: <22516.1285265739@redhat.com>
On Thu, 2010-09-23 at 19:15 +0100, David Howells wrote:
> The problem is that the second matcher (looking for " to \\n) matches on more
> than just the logfunction line. Instrumenting the code supplied by your patch
> thusly:
[]
> I suspect checkpatch doesn't handle #defines correctly, and goes beyond their
> end looking for a semicolon.
Hi David.
Exactly right. Andy has a version in his testing directory
that fixes this #define run-on block and speeds up checkpatch
runtime rather a lot for certain files like .h files that have
nothing but #defines.
Try applying my patch to this newer version:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
next prev parent reply other threads:[~2010-09-23 18:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-07 13:09 David Howells
2010-09-07 18:00 ` Andy Whitcroft
2010-09-07 19:41 ` Joe Perches
2010-09-22 15:33 ` David Howells
2010-09-22 17:43 ` David Howells
2010-09-23 18:15 ` David Howells
2010-09-23 18:27 ` Joe Perches [this message]
2010-09-23 18:54 ` David Howells
2010-09-23 20:31 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285266454.31572.29.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®