From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756349Ab0IWXiI (ORCPT ); Thu, 23 Sep 2010 19:38:08 -0400 Received: from smtp109.sbc.mail.gq1.yahoo.com ([67.195.14.39]:37319 "HELO smtp109.sbc.mail.gq1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756292Ab0IWXiE (ORCPT ); Thu, 23 Sep 2010 19:38:04 -0400 X-Yahoo-SMTP: fzDSGlOswBCWnIOrNw7KwwK1j9PqyNbe5PtLKiS4dDU.UNl_t6bdEZu9tTLW X-YMail-OSG: xn3DdZwVM1naf3YNSKWepjZ5oCQZGmikXrwOpVtudEm__FX 0xDZDuN06_Yu8TuQB17Dkyf46xL5EyAxhwIWNrqIuCZFY_ttglP3Cw7BEVL5 DOcPCyooSJwF0VlgFWizSipy37i.UHwZoXXLJkBM6qhdFFtU1rK4kOliAC1q t2zWRLXeBgdHdxiK92q4w5_MEBkBn8EuHxx93i53tAtQBBAcUprhu8OgV8pL o3arozi9hR323o0aM32lJ5OtvwNkfxUlNsBekwDhmI_OWykgYYtj2_tGozOx C6LOKrEIThV4YXhLMh2BD7s60j9_LEo5WgD8p8HVisvQB6L80caq_NWAC.Qi TsFFSIi5AtOniaIjDVQ-- X-Yahoo-Newman-Property: ymail-3 From: "Nicholas A. Bellinger" To: linux-scsi , linux-kernel , Vasu Dev , Tim Chen , Andi Kleen , Matthew Wilcox , James Bottomley , Mike Christie Cc: James Smart , Andrew Vasquez , FUJITA Tomonori , Hannes Reinecke , Joe Eykholt , Christoph Hellwig , MPTFusionLinux , "eata.c maintainer" , Nicholas Bellinger Subject: [RFC v3 04/15] libfc: Remove host_lock unlock() + lock() from fc_queuecommand() Date: Thu, 23 Sep 2010 16:38:00 -0700 Message-Id: <1285285080-16411-1-git-send-email-nab@linux-iscsi.org> X-Mailer: git-send-email 1.5.6.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Bellinger This patch removes the now legacy host_lock unlock() + lock() optimization fc_fcp.c:fc_queuecommand() Signed-off-by: Nicholas A. Bellinger --- drivers/scsi/libfc/fc_fcp.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index c797f6b..140cd94 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c @@ -1751,8 +1751,7 @@ static inline int fc_fcp_lport_queue_ready(struct fc_lport *lport) * @cmd: The scsi_cmnd to be executed * @done: The callback function to be called when the scsi_cmnd is complete * - * This is the i/o strategy routine, called by the SCSI layer. This routine - * is called with the host_lock held. + * This is the i/o strategy routine, called by the SCSI layer. */ int fc_queuecommand(struct scsi_cmnd *sc_cmd, void (*done)(struct scsi_cmnd *)) { @@ -1772,7 +1771,6 @@ int fc_queuecommand(struct scsi_cmnd *sc_cmd, void (*done)(struct scsi_cmnd *)) done(sc_cmd); return 0; } - spin_unlock_irq(lport->host->host_lock); if (!*(struct fc_remote_port **)rport->dd_data) { /* @@ -1849,7 +1847,6 @@ int fc_queuecommand(struct scsi_cmnd *sc_cmd, void (*done)(struct scsi_cmnd *)) rc = SCSI_MLQUEUE_HOST_BUSY; } out: - spin_lock_irq(lport->host->host_lock); return rc; } EXPORT_SYMBOL(fc_queuecommand); -- 1.7.3