From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756664Ab0IWXiw (ORCPT ); Thu, 23 Sep 2010 19:38:52 -0400 Received: from smtp126.sbc.mail.sp1.yahoo.com ([69.147.65.185]:34795 "HELO smtp126.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1756629Ab0IWXit (ORCPT ); Thu, 23 Sep 2010 19:38:49 -0400 X-Yahoo-SMTP: fzDSGlOswBCWnIOrNw7KwwK1j9PqyNbe5PtLKiS4dDU.UNl_t6bdEZu9tTLW X-YMail-OSG: TpS9jBkVM1nOqAA_J7i0Wt1i1WTZKxXYEgViTHax.rypPYn ZdPh9qRew3ROejTvOQyX3xj3o96oL3u9IMOt7vhBXN8uAnLf2NXlipw69aj4 7BgjlBuSLp.pJzOGkf.VbrihL7996WgNBV8prlSyXE95aGH1gRoB0alJNPbq paFU_kmJn_czSRmULrFpito55FtnGu641c9MQtUPz3N5tmSK2LxhDq_W8k.B yNfQHR16p02fErXciBiVYw4CmGE8SENr0YlPW2ItUwYL62PlZ870K2E4WDpA 9KGwzk_S9eijzoGy5J_1Zad4lPdPd0kdQF2yDeYr51O1ObEk4XGJbvXi1ViI .LFqWcNt1pz1wkHGa_w-- X-Yahoo-Newman-Property: ymail-3 From: "Nicholas A. Bellinger" To: linux-scsi , linux-kernel , Vasu Dev , Tim Chen , Andi Kleen , Matthew Wilcox , James Bottomley , Mike Christie Cc: James Smart , Andrew Vasquez , FUJITA Tomonori , Hannes Reinecke , Joe Eykholt , Christoph Hellwig , MPTFusionLinux , "eata.c maintainer" , Nicholas Bellinger Subject: [RFC v3 09/15] fnic: Remove host_lock unlock() + lock() from fnic_queuecommand() Date: Thu, 23 Sep 2010 16:38:47 -0700 Message-Id: <1285285127-16511-1-git-send-email-nab@linux-iscsi.org> X-Mailer: git-send-email 1.5.6.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Nicholas Bellinger This patch removes the now legacy host_lock unlock() + lock() optimization fnic_scsi.c:fnic_queuecommand() Signed-off-by: Nicholas A. Bellinger --- drivers/scsi/fnic/fnic_scsi.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c index 198cbab..7cf3372 100644 --- a/drivers/scsi/fnic/fnic_scsi.c +++ b/drivers/scsi/fnic/fnic_scsi.c @@ -373,13 +373,6 @@ int fnic_queuecommand(struct scsi_cmnd *sc, void (*done)(struct scsi_cmnd *)) if (lp->state != LPORT_ST_READY || !(lp->link_up)) return SCSI_MLQUEUE_HOST_BUSY; - /* - * Release host lock, use driver resource specific locks from here. - * Don't re-enable interrupts in case they were disabled prior to the - * caller disabling them. - */ - spin_unlock(lp->host->host_lock); - /* Get a new io_req for this SCSI IO */ fnic = lport_priv(lp); @@ -452,8 +445,6 @@ int fnic_queuecommand(struct scsi_cmnd *sc, void (*done)(struct scsi_cmnd *)) } } out: - /* acquire host lock before returning to SCSI */ - spin_lock(lp->host->host_lock); return ret; } -- 1.7.3