From: Eric Dumazet <eric.dumazet@gmail.com>
To: Venkatesh Pallipadi <venki@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, Paul Turner <pjt@google.com>
Subject: Re: [PATCH] si time accounting accounts bh_disable'd time to si
Date: Mon, 27 Sep 2010 23:16:09 +0200 [thread overview]
Message-ID: <1285622169.2512.135.camel@edumazet-laptop> (raw)
In-Reply-To: <AANLkTim2=ZN=DMFCYcvVx31mOPd40q+EoTVfx-bqMCob@mail.gmail.com>
Le lundi 27 septembre 2010 à 14:11 -0700, Venkatesh Pallipadi a écrit :
> On Mon, Sep 27, 2010 at 1:53 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > But softirq handlers sometime call functions that might disable bh
> > again. It would be good to not switch softirq time to system time ;)
>
> Yes. Good point :-). I should rather have
> +#define in_serving_softirq() (softirq_count() & SOFTIRQ_OFFSET)
>
> >
> > Shouldnt we reserve a bit (high order bit out of 8) instead ?
> >
> > * PREEMPT_MASK: 0x000000ff
> > * SOFTIRQ_MASK: 0x0000ff00
> > * SERVING_SOFTIRQ: 0x00008000
> > * HARDIRQ_MASK: 0x03ff0000
> > * NMI_MASK: 0x04000000
>
> Things will be very much similar using higher order bit or lower order
> bit. Somehow I felt using lower order bit was cleaner...
>
No problem, I now undertand what you wanted to achieve ;)
next prev parent reply other threads:[~2010-09-27 21:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-17 1:56 [PATCH 0/6] Proper kernel irq time accounting Venkatesh Pallipadi
2010-09-17 1:56 ` [PATCH 1/6] Consolidate account_system_vtime extern declaration Venkatesh Pallipadi
2010-09-17 1:56 ` [PATCH 2/6] Add IRQ_TIME_ACCOUNTING, finer accounting of CPU irq time Venkatesh Pallipadi
2010-09-19 11:11 ` Peter Zijlstra
2010-09-20 17:13 ` Venkatesh Pallipadi
2010-09-20 17:23 ` Peter Zijlstra
2010-09-19 11:21 ` Peter Zijlstra
2010-09-19 11:42 ` Peter Zijlstra
2010-09-19 12:01 ` Peter Zijlstra
2010-09-20 7:27 ` Martin Schwidefsky
2010-09-20 9:27 ` Peter Zijlstra
2010-09-20 17:16 ` Venkatesh Pallipadi
2010-09-20 17:26 ` Peter Zijlstra
2010-09-27 20:35 ` [PATCH] si time accounting accounts bh_disable'd time to si Venkatesh Pallipadi
2010-09-27 20:53 ` Eric Dumazet
2010-09-27 21:11 ` Venkatesh Pallipadi
2010-09-27 21:16 ` Eric Dumazet [this message]
2010-09-30 11:17 ` Peter Zijlstra
2010-09-17 1:56 ` [PATCH 3/6] x86: Add IRQ_TIME_ACCOUNTING in x86 Venkatesh Pallipadi
2010-09-17 1:56 ` [PATCH 4/6] sched: Do not account irq time to current task Venkatesh Pallipadi
2010-09-19 11:28 ` Peter Zijlstra
2010-09-20 17:33 ` Venkatesh Pallipadi
2010-09-20 17:38 ` Peter Zijlstra
2010-09-20 17:40 ` Venkatesh Pallipadi
2010-09-17 1:56 ` [PATCH 5/6] sched: Remove irq time from available CPU power Venkatesh Pallipadi
2010-09-19 11:31 ` Peter Zijlstra
2010-09-20 17:38 ` Venkatesh Pallipadi
2010-09-17 1:56 ` [PATCH 6/6] Export per cpu hardirq and softirq time in proc Venkatesh Pallipadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285622169.2512.135.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=balbir@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=schwidefsky@de.ibm.com \
--cc=tglx@linutronix.de \
--cc=venki@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®