From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755266Ab0I0VgV (ORCPT ); Mon, 27 Sep 2010 17:36:21 -0400 Received: from mail.solarflare.com ([216.237.3.220]:9159 "EHLO exchange.solarflare.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930Ab0I0VgU (ORCPT ); Mon, 27 Sep 2010 17:36:20 -0400 Subject: Re: [PATCH v11 17/17]add two new ioctls for mp device. From: Ben Hutchings To: xiaohui.xin@intel.com Cc: netdev@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@elte.hu, davem@davemloft.net, herbert@gondor.hengli.com.au, jdike@linux.intel.com In-Reply-To: References: <1285388855-27410-1-git-send-email-xiaohui.xin@intel.com> Content-Type: text/plain; charset="UTF-8" Organization: Solarflare Communications Date: Mon, 27 Sep 2010 22:36:15 +0100 Message-ID: <1285623375.2263.552.camel@achroite.uk.solarflarecom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.2 (2.30.2-4.fc13) Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 27 Sep 2010 21:36:19.0376 (UTC) FILETIME=[05ABAB00:01CB5E8C] X-TM-AS-Product-Ver: SMEX-8.0.0.1181-6.500.1024-17668.005 X-TM-AS-Result: No--11.564900-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2010-09-25 at 12:27 +0800, xiaohui.xin@intel.com wrote: > From: Xin Xiaohui > > The patch add two ioctls for mp device. > One is for userspace to query how much memory locked to make mp device > run smoothly. Another one is for userspace to set how much meory locked > it really wants. [...] > diff --git a/include/linux/mpassthru.h b/include/linux/mpassthru.h > index ba8f320..083e9f7 100644 > --- a/include/linux/mpassthru.h > +++ b/include/linux/mpassthru.h > @@ -7,6 +7,8 @@ > /* ioctl defines */ > #define MPASSTHRU_BINDDEV _IOW('M', 213, int) > #define MPASSTHRU_UNBINDDEV _IO('M', 214) > +#define MPASSTHRU_SET_MEM_LOCKED _IOW('M', 215, unsigned long) > +#define MPASSTHRU_GET_MEM_LOCKED_NEED _IOR('M', 216, unsigned long) [...] These will need compat handling. You can avoid that by defining them to use a parameter type of u32 or u64. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked.