From: Phil Carmody <ext-phil.2.carmody@nokia.com>
To: mingo@elte.hu, gregkh@suse.de, linux@arm.linux.org.uk, tony@atomide.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, travis@sgi.com,
akataria@vmware.com
Subject: [PATCHv2 0/4] Improve fallback LPJ calculation
Date: Tue, 28 Sep 2010 13:44:56 +0300 [thread overview]
Message-ID: <1285670700-11099-1-git-send-email-ext-phil.2.carmody@nokia.com> (raw)
The guts of this patchset are in patch 2/4. The motivation for that patch
is that currently our OMAP calibrates itself using the trial-and-error
binary chop fallback that some other architectures no longer need to
perform. This is a lengthy process, taking 0.2s in an environment where
boot time is of great interest. Presumably this is an equivalent win on
all ARM architectures.
Patch 2/4 has two optimisations. Firstly, it replaces the initial repeated-
doubling to find the relevant power of 2 with a tight loop that just does
as much as it can in a jiffy. Secondly, it doesn't binary chop over an
entire power of 2 range, it choses a much smaller range based on how much
it squeezed in, and failed to squeeze in, during the first stage. Both
are significant optimisations, and bring our calibration down from 23
jiffies to 5, and, in the process, often arrive at a more accurate lpj
value.
The 'bands' and 'sub-logarithmic' growth may look over-engineered, but
they cost a small level of in inaccuracy of the initial guess (for all
architectures) in order to avoid the very large inaccuracies that appeared
during testing (on x86_64 architectures, and presumably others with less
metronomic operation). Note that due to the existence of the TSC and
other timers, the x86_64 will not typically use this fallback routine,
but I wanted to code defensively, able to cope with all kinds of processor
behaviours and kernel command line options.
Patch 3/4 is an additional trap for the nightmare scenario where the
initial estimate is very inaccurate, possibly due to things like SMIs.
It simply retries with a larger bound.
1/4 is simply cosmetic to prepare for 2/4.
4/4 is simply to assist testing and not intended for integration.
Changes since initial RFC:
- More informational commit messages
- Inserted patch 3/4 after discovering that x86_64 had a failure case.
--
Cheers,
Phil
next reply other threads:[~2010-09-28 10:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 10:44 Phil Carmody [this message]
2010-09-28 10:44 ` [PATCH 1/4] calibrate: extract fall-back calculation into own helper Phil Carmody
2010-09-28 10:44 ` [PATCH 2/4] calibrate: home in on correct lpj value more quickly Phil Carmody
2010-09-28 10:44 ` [PATCH 3/4] calibrate: retry with wider bounds when converge seems to fail Phil Carmody
2010-09-28 10:45 ` [PATCH 4/4] DO NOT INTEGRATE: test-only timing Phil Carmody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285670700-11099-1-git-send-email-ext-phil.2.carmody@nokia.com \
--to=ext-phil.2.carmody@nokia.com \
--cc=akataria@vmware.com \
--cc=gregkh@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@elte.hu \
--cc=tony@atomide.com \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®