From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757421Ab0I1RI3 (ORCPT ); Tue, 28 Sep 2010 13:08:29 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:51574 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757354Ab0I1RIP (ORCPT ); Tue, 28 Sep 2010 13:08:15 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=FwXCz0NSy3ActQGNW085sYlVE0pDe13sYh1a/FOE07gVU+zvDiLoGV3Ts77RtJf0XN 6+7kt3TbdBiyBIAXumllysjFzb46SgBxD6UIi1VMuyGmBzhJEcQsqRWEZD/TE2Ei9suZ oJrBBhOWz3ge9ZPU1GgDb2gIeC7WXuVtnMic4= From: Vasiliy Kulikov To: kernel-janitors@vger.kernel.org Cc: Greg Kroah-Hartman , "David S. Miller" , Jiri Pirko , Henk de Groot , Andrew Morton , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH 9/9] staging: wlags49_h2: use free_netdev(netdev) instead of kfree() Date: Tue, 28 Sep 2010 21:08:11 +0400 Message-Id: <1285693692-4805-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Freeing netdev without free_netdev() leads to net, tx leaks. I might lead to dereferencing freed pointer. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) @@ struct net_device* dev; @@ -kfree(dev) +free_netdev(dev) Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/staging/wlags49_h2/wl_netdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/wlags49_h2/wl_netdev.c b/drivers/staging/wlags49_h2/wl_netdev.c index e2a7ad0..954bece 100644 --- a/drivers/staging/wlags49_h2/wl_netdev.c +++ b/drivers/staging/wlags49_h2/wl_netdev.c @@ -1586,7 +1586,7 @@ void wl_wds_device_dealloc( struct wl_private *lp ) dev_wds->flags &= ~( IFF_UP | IFF_RUNNING ); } - kfree( dev_wds ); + free_netdev(dev_wds); lp->wds_port[count].dev = NULL; } } -- 1.7.0.4