mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: linux-kernel@vger.kernel.org
Cc: john.williams@petalogix.com, edgar.iglesias@gmail.com,
	duyl@xilinx.com, linnj@xilinx.com, grant.likely@secretlab.ca,
	microblaze-uclinux@itee.uq.edu.au,
	Michal Simek <monstr@monstr.eu>,
	"David S. Miller" <davem@davemloft.net>,
	Tejun Heo <tj@kernel.org>,
	devicetree-discuss@lists.ozlabs.org
Subject: [PATCH 3/7] of: Fix uart16550 initialization on little-endian systems
Date: Wed, 29 Sep 2010 15:52:14 +1000	[thread overview]
Message-ID: <1285739538-29058-4-git-send-email-monstr@monstr.eu> (raw)
In-Reply-To: <1285739538-29058-3-git-send-email-monstr@monstr.eu>

Convert values from big-endian to cpu-endian.

Signed-off-by: Michal Simek <monstr@monstr.eu>
CC: Grant Likely <grant.likely@secretlab.ca>
CC: "David S. Miller" <davem@davemloft.net>
CC: Tejun Heo <tj@kernel.org>
CC: linux-kernel@vger.kernel.org
CC: devicetree-discuss@lists.ozlabs.org
---
 drivers/serial/of_serial.c |   17 ++++++++++-------
 1 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/serial/of_serial.c b/drivers/serial/of_serial.c
index 2af8fd1..0e4d894 100644
--- a/drivers/serial/of_serial.c
+++ b/drivers/serial/of_serial.c
@@ -31,17 +31,19 @@ static int __devinit of_platform_serial_setup(struct platform_device *ofdev,
 {
 	struct resource resource;
 	struct device_node *np = ofdev->dev.of_node;
-	const unsigned int *clk, *spd;
+	const unsigned int *spd;
+	unsigned int clk;
 	const u32 *prop;
 	int ret, prop_size;
 
 	memset(port, 0, sizeof *port);
 	spd = of_get_property(np, "current-speed", NULL);
-	clk = of_get_property(np, "clock-frequency", NULL);
-	if (!clk) {
+	prop = of_get_property(np, "clock-frequency", NULL);
+	if (!prop) {
 		dev_warn(&ofdev->dev, "no clock-frequency property set\n");
 		return -ENODEV;
 	}
+	clk = be32_to_cpup(prop);
 
 	ret = of_address_to_resource(np, 0, &resource);
 	if (ret) {
@@ -55,23 +57,24 @@ static int __devinit of_platform_serial_setup(struct platform_device *ofdev,
 	/* Check for shifted address mapping */
 	prop = of_get_property(np, "reg-offset", &prop_size);
 	if (prop && (prop_size == sizeof(u32)))
-		port->mapbase += *prop;
+		port->mapbase += be32_to_cpup(prop);
 
 	/* Check for registers offset within the devices address range */
 	prop = of_get_property(np, "reg-shift", &prop_size);
 	if (prop && (prop_size == sizeof(u32)))
-		port->regshift = *prop;
+		port->regshift = be32_to_cpup(prop);
 
 	port->irq = irq_of_parse_and_map(np, 0);
 	port->iotype = UPIO_MEM;
 	port->type = type;
-	port->uartclk = *clk;
+	port->uartclk = clk;
 	port->flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_IOREMAP
 		| UPF_FIXED_PORT | UPF_FIXED_TYPE;
 	port->dev = &ofdev->dev;
+
 	/* If current-speed was set, then try not to change it. */
 	if (spd)
-		port->custom_divisor = *clk / (16 * (*spd));
+		port->custom_divisor = clk / (16 * be32_to_cpup(spd));
 
 	return 0;
 }
-- 
1.5.5.1


  reply	other threads:[~2010-09-29  5:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29  5:52 Microblaze little-endian port + driver changes Michal Simek
2010-09-29  5:52 ` [PATCH 1/7] of: GPIO: Fix OF probing on little-endian systems Michal Simek
2010-09-29  5:52   ` [PATCH 2/7] of: MTD: " Michal Simek
2010-09-29  5:52     ` Michal Simek [this message]
2010-09-29  5:52       ` [PATCH 4/7] net: emaclite: Add support for little-endian platforms Michal Simek
2010-09-29  5:52         ` [PATCH 5/7] microblaze: Add PVR for endians plus detection Michal Simek
2010-09-29  5:52           ` [PATCH 6/7] microblaze: KGDB little endian support Michal Simek
2010-09-29  5:52             ` [PATCH 7/7] microblaze: Add support for little-endian Microblaze Michal Simek
2010-09-29  6:27               ` Grant Likely
     [not found]                 ` <AANLkTikvfr90AZRJXz6CQg2FJTG13ygzxp0J9OpkL03c@mail.gmail.com>
2010-09-29  7:48                   ` Grant Likely
2010-09-29  6:12           ` [PATCH 5/7] microblaze: Add PVR for endians plus detection Grant Likely
2010-09-29  6:11         ` [PATCH 4/7] net: emaclite: Add support for little-endian platforms Grant Likely
2010-09-29  6:27           ` David Miller
2010-09-29  7:33             ` Michal Simek
2010-09-29  6:29       ` [PATCH 3/7] of: Fix uart16550 initialization on little-endian systems Grant Likely
2010-09-29  6:29     ` [PATCH 2/7] of: MTD: Fix OF probing " Grant Likely
2010-09-29  6:30   ` [PATCH 1/7] of: GPIO: " Grant Likely
2010-10-10  6:02 ` Microblaze little-endian port + driver changes Grant Likely
2010-10-10 23:34   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285739538-29058-4-git-send-email-monstr@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=davem@davemloft.net \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=duyl@xilinx.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=john.williams@petalogix.com \
    --cc=linnj@xilinx.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®