From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754160Ab0I2H5U (ORCPT ); Wed, 29 Sep 2010 03:57:20 -0400 Received: from smtp126.sbc.mail.sp1.yahoo.com ([69.147.65.185]:34525 "HELO smtp126.sbc.mail.sp1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753178Ab0I2H5Q (ORCPT ); Wed, 29 Sep 2010 03:57:16 -0400 X-Yahoo-SMTP: fzDSGlOswBCWnIOrNw7KwwK1j9PqyNbe5PtLKiS4dDU.UNl_t6bdEZu9tTLW X-YMail-OSG: gdkociwVM1nPmNTBnmHbXvaHrojYEKFt_Hf8kKlVV5JgeE8 Hk9drzUtvUeTL_6n5H0Nqkvbmd69X7RTFdra2XXEpwt6IOvZD3BPQRgyQ0ZV GtTgISGzgTNlui3WJENvvZdea9NhdwLxuFrML.0ruRHulw5U5HNASNWgjmBJ k4btZi5PxmOhyO2FlnKzM7ylUTcR2aHeig1pyiip3nmZqEcZWz9YH8jGWAWp XsSOGpSaP8JpODoU3Vh.GQE0OkOVP1oM.D5McdvXi2z27RXAhGG_LK0DMsGS hoOXm8VbTFxKlWsbokU0yuvuHCPoSxpwXl8YCZx1zwgDUP8HSpCzOAg-- X-Yahoo-Newman-Property: ymail-3 Subject: Re: [PATCH] zfcp: Remove scsi_cmnd->serial_number from debug traces From: "Nicholas A. Bellinger" To: Christof Schmitt Cc: Mike Christie , Joe Eykholt , linux-scsi , linux-kernel , Vasu Dev , Tim Chen , Andi Kleen , Matthew Wilcox , James Bottomley , James Smart , Andrew Vasquez , FUJITA Tomonori , Hannes Reinecke , Christoph Hellwig In-Reply-To: <20100928081103.GA3790@schmichrtp.mainz.de.ibm.com> References: <1284747709-20862-1-git-send-email-nab@linux-iscsi.org> <4C93BB8E.2080501@cisco.com> <4C9427B6.9050404@cs.wisc.edu> <1284839878.13344.300.camel@haakon2.linux-iscsi.org> <20100927140551.GB8473@schmichrtp.mainz.de.ibm.com> <1285628548.8880.64.camel@haakon2.linux-iscsi.org> <20100928081103.GA3790@schmichrtp.mainz.de.ibm.com> Content-Type: text/plain Date: Wed, 29 Sep 2010 00:52:59 -0700 Message-Id: <1285746779.18417.34.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2010-09-28 at 10:11 +0200, Christof Schmitt wrote: > From: Christof Schmitt > > With the change that drivers have to explicitly request the serial > number for SCSI commands, this field should not be part of the zfcp > traces. It is not worth the effort to request the serial number only > for tracing purposes, so simply remove this field from the debug > traces. > > Reviewed-by: Swen Schillig > Signed-off-by: Christof Schmitt > --- Hi Christof, This patch has been commited into the drop-host_lock-v5 branch and will be included in the next RFC posting. Thanks! --nab > drivers/s390/scsi/zfcp_dbf.c | 4 ---- > drivers/s390/scsi/zfcp_dbf.h | 2 -- > 2 files changed, 6 deletions(-) > > --- a/drivers/s390/scsi/zfcp_dbf.c > +++ b/drivers/s390/scsi/zfcp_dbf.c > @@ -154,7 +154,6 @@ void _zfcp_dbf_hba_fsf_response(const ch > scsi_cmnd = (struct scsi_cmnd *)fsf_req->data; > if (scsi_cmnd) { > response->u.fcp.cmnd = (unsigned long)scsi_cmnd; > - response->u.fcp.serial = scsi_cmnd->serial_number; > response->u.fcp.data_dir = > qtcb->bottom.io.data_direction; > } > @@ -330,7 +329,6 @@ static void zfcp_dbf_hba_view_response(c > break; > zfcp_dbf_out(p, "data_direction", "0x%04x", r->u.fcp.data_dir); > zfcp_dbf_out(p, "scsi_cmnd", "0x%0Lx", r->u.fcp.cmnd); > - zfcp_dbf_out(p, "scsi_serial", "0x%016Lx", r->u.fcp.serial); > *p += sprintf(*p, "\n"); > break; > > @@ -881,7 +879,6 @@ void _zfcp_dbf_scsi(const char *tag, con > } > rec->scsi_result = scsi_cmnd->result; > rec->scsi_cmnd = (unsigned long)scsi_cmnd; > - rec->scsi_serial = scsi_cmnd->serial_number; > memcpy(rec->scsi_opcode, scsi_cmnd->cmnd, > min((int)scsi_cmnd->cmd_len, > ZFCP_DBF_SCSI_OPCODE)); > @@ -950,7 +947,6 @@ static int zfcp_dbf_scsi_view_format(deb > zfcp_dbf_out(&p, "scsi_lun", "0x%08x", r->scsi_lun); > zfcp_dbf_out(&p, "scsi_result", "0x%08x", r->scsi_result); > zfcp_dbf_out(&p, "scsi_cmnd", "0x%0Lx", r->scsi_cmnd); > - zfcp_dbf_out(&p, "scsi_serial", "0x%016Lx", r->scsi_serial); > zfcp_dbf_outd(&p, "scsi_opcode", r->scsi_opcode, ZFCP_DBF_SCSI_OPCODE, > 0, ZFCP_DBF_SCSI_OPCODE); > zfcp_dbf_out(&p, "scsi_retries", "0x%02x", r->scsi_retries); > --- a/drivers/s390/scsi/zfcp_dbf.h > +++ b/drivers/s390/scsi/zfcp_dbf.h > @@ -110,7 +110,6 @@ struct zfcp_dbf_hba_record_response { > union { > struct { > u64 cmnd; > - u64 serial; > u32 data_dir; > } fcp; > struct { > @@ -206,7 +205,6 @@ struct zfcp_dbf_scsi_record { > u32 scsi_lun; > u32 scsi_result; > u64 scsi_cmnd; > - u64 scsi_serial; > #define ZFCP_DBF_SCSI_OPCODE 16 > u8 scsi_opcode[ZFCP_DBF_SCSI_OPCODE]; > u8 scsi_retries;