mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	Douglas Gilbert <dgilbert@interlog.com>,
	Jens Axboe <axboe@kernel.dk>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Mike Christie <michaelc@cs.wisc.edu>,
	Hannes Reinecke <hare@suse.de>,
	James Bottomley <James.Bottomley@suse.de>,
	Konrad Rzeszutek Wilk <konrad@darnok.org>,
	Boaz Harrosh <bharrosh@panasas.com>,
	Richard Sharpe <realrichardsharpe@gmail.com>
Subject: Re: [PATCH 1/3] tcm: Add Thin Provisioning / UNMAP emulation and Block Limits VPD page
Date: Wed, 29 Sep 2010 02:05:56 -0700	[thread overview]
Message-ID: <1285751156.18417.57.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <yq1sk0taeal.fsf@sermon.lab.mkp.net>

On Tue, 2010-09-28 at 14:55 -0400, Martin K. Petersen wrote:
> >>>>> "nab" == Nicholas A Bellinger <nab@linux-iscsi.org> writes:
> 
> nab> This patch also adds the Block Limits VPD (0xb0) page
> 
> You should add the Thin Provisioning VPD page as well and set TPU and/or
> TPWS.
> 

Greetings mkp,

So I was looking at adding this VPD page orginally to set TPU=1 w/ DP=0
(because I don't believe there is currently way to get build the
PROVISIONING GROUP DESCRIPTORs from Block Discard knowledge), but I
ended getting a bit confused by the THRESHOLD EXPONENT, and what value
this should returned for the TCM/IBLOCK and TCM/FILEIO backstores when
blk_queue_discard()==1 is enabled.

Since this is currently not implemented in scsi_debug.c or used in any
way by sd.c AFAICT, do you have any additional information on how this
should be determined together with the UNMAP -> blk_issue_discard()
emulation bits..?

Thanks!

--nab


      reply	other threads:[~2010-09-29  9:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-27 22:51 Nicholas A. Bellinger
2010-09-28 18:55 ` Martin K. Petersen
2010-09-29  9:05   ` Nicholas A. Bellinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285751156.18417.57.camel@haakon2.linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=James.Bottomley@suse.de \
    --cc=axboe@kernel.dk \
    --cc=bharrosh@panasas.com \
    --cc=dgilbert@interlog.com \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=konrad@darnok.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=michaelc@cs.wisc.edu \
    --cc=realrichardsharpe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®