From: Rahul Ruikar <rahul.ruikar@gmail.com>
To: Greg Kroah-Hartman <gregkh@suse.de>, Tejun Heo <tj@kernel.org>,
asanchez@neurowork.net, rjw@sisk.pl
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Rahul Ruikar <rahul.ruikar@gmail.com>
Subject: [PATCH] usb: core: endpoint: Fix error path
Date: Sat, 2 Oct 2010 12:18:41 +0530 [thread overview]
Message-ID: <1286002121-3694-1-git-send-email-rahul.ruikar@gmail.com> (raw)
In function usb_create_ep_devs()
call put_device() when device_register() fails.
Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
---
drivers/usb/core/endpoint.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/core/endpoint.c b/drivers/usb/core/endpoint.c
index 3788e73..cab126d 100644
--- a/drivers/usb/core/endpoint.c
+++ b/drivers/usb/core/endpoint.c
@@ -195,8 +195,10 @@ int usb_create_ep_devs(struct device *parent,
device_enable_async_suspend(&ep_dev->dev);
retval = device_register(&ep_dev->dev);
- if (retval)
+ if (retval) {
+ put_device(&ep_dev->dev);
goto error_register;
+ }
endpoint->ep_dev = ep_dev;
return retval;
--
1.7.2.3
next reply other threads:[~2010-10-02 6:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-02 6:48 Rahul Ruikar [this message]
2010-10-02 7:45 ` Ming Lei
2010-10-02 8:46 ` Rahul Ruikar
2010-10-02 9:58 ` Ming Lei
2010-10-02 10:14 ` Rahul Ruikar
2010-10-02 10:28 ` Ming Lei
2010-10-06 20:23 ` Greg KH
2010-10-07 4:03 ` Rahul Ruikar
2010-10-07 4:01 Rahul Ruikar
2010-10-07 4:03 ` Rahul Ruikar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286002121-3694-1-git-send-email-rahul.ruikar@gmail.com \
--to=rahul.ruikar@gmail.com \
--cc=asanchez@neurowork.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome