From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932818Ab0JEJ7R (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Oct 2010 05:59:17 -0400
Received: from smtp.nokia.com ([192.100.105.134]:22421 "EHLO
	mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932802Ab0JEJ7Q (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Oct 2010 05:59:16 -0400
Subject: Re: [PATCH 1/1] omap: Ptr "isr_reg" tracked as NULL was
 dereferenced
From: Evgeny Kuznetsov <EXT-Eugeny.Kuznetsov@nokia.com>
To: balbi@ti.com
Cc: "tony@atomide.com" <tony@atomide.com>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "zmc@lurian.net" <zmc@lurian.net>,
        "a.j.buxton@gmail.com" <a.j.buxton@gmail.com>
In-Reply-To: <20101005093206.GB2977@legolas.emea.dhcp.ti.com>
References: <cover.1286261378.git.EXT-Eugeny.Kuznetsov@nokia.com>
	 <131d16236d19895323fca2f058d65f1f116bacad.1286261378.git.EXT-Eugeny.Kuznetsov@nokia.com>
	 <20101005093206.GB2977@legolas.emea.dhcp.ti.com>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 05 Oct 2010 13:55:19 +0400
Message-ID: <1286272519.24366.33.camel@ekuznets-lx-nokia>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.1 
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 05 Oct 2010 09:58:53.0716 (UTC) FILETIME=[EB04AD40:01CB6473]
X-Nokia-AV: Clean
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Yes, but no log in that case.

Regards,
Evgeny

On Tue, 2010-10-05 at 12:32 +0300, ext Felipe Balbi wrote:
> Hi,
> 
> On Tue, Oct 05, 2010 at 03:42:10AM -0500, Evgeny Kuznetsov wrote:
> >+	if (!isr_reg) {
> >+		printk(KERN_ERR "FATAL: Incorrect GPIO method %i\n",
> >+				bank->method);
> >+		BUG();
> >+		}
> 
> this could be simply:
> 
> BUG_ON(!isr_reg);
>