From: Borislav Petkov <bp@amd64.org>
To: <norsk5@yahoo.com>
Cc: <linux-edac@vger.kernel.org>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>,
Borislav Petkov <borislav.petkov@amd.com>
Subject: [PATCH 7/8] EDAC, MCE: Fix FR MCEs decoding
Date: Tue, 5 Oct 2010 12:54:07 +0200 [thread overview]
Message-ID: <1286276048-20556-8-git-send-email-bp@amd64.org> (raw)
In-Reply-To: <1286276048-20556-1-git-send-email-bp@amd64.org>
From: Borislav Petkov <borislav.petkov@amd.com>
Those are N/A on K8, so don't decode them there.
Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
---
drivers/edac/mce_amd.c | 14 ++++++++++----
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/edac/mce_amd.c b/drivers/edac/mce_amd.c
index cf6d44a..82dc0de 100644
--- a/drivers/edac/mce_amd.c
+++ b/drivers/edac/mce_amd.c
@@ -491,11 +491,17 @@ EXPORT_SYMBOL_GPL(amd_decode_nb_mce);
static void amd_decode_fr_mce(struct mce *m)
{
+ if (boot_cpu_data.x86 == 0xf)
+ goto wrong_fr_mce;
+
/* we have only one error signature so match all fields at once. */
- if ((m->status & 0xffff) == 0x0f0f)
- pr_emerg(HW_ERR " FR Error: CPU Watchdog timer expire.\n");
- else
- pr_emerg(HW_ERR "Corrupted FR MCE info?\n");
+ if ((m->status & 0xffff) == 0x0f0f) {
+ pr_emerg(HW_ERR "FR Error: CPU Watchdog timer expire.\n");
+ return;
+ }
+
+wrong_fr_mce:
+ pr_emerg(HW_ERR "Corrupted FR MCE info?\n");
}
static inline void amd_decode_err_code(u16 ec)
--
1.7.3.1.50.g1e633
next prev parent reply other threads:[~2010-10-05 10:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 10:54 [PATCH 0/8] MCE decoding on F14h Borislav Petkov
2010-10-05 10:54 ` [PATCH 1/8] EDAC, MCE: Rework MCE injection Borislav Petkov
2010-10-05 10:54 ` [PATCH 2/8] EDAC, MCE: Rename files Borislav Petkov
2010-10-05 10:54 ` [PATCH 3/8] EDAC, MCE: Adjust DC decoders to F14h Borislav Petkov
2010-10-05 10:54 ` [PATCH 4/8] EDAC, MCE: Adjust IC " Borislav Petkov
2010-10-05 10:54 ` [PATCH 5/8] EDAC, MCE: Warn about LS MCEs on F14h Borislav Petkov
2010-10-05 10:54 ` [PATCH 6/8] EDAC, MCE: Complete NB MCE decoders Borislav Petkov
2010-10-05 10:54 ` Borislav Petkov [this message]
2010-10-05 10:54 ` [PATCH 8/8] EDAC, MCE: Enable MCE decoding on F14h Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286276048-20556-8-git-send-email-bp@amd64.org \
--to=bp@amd64.org \
--cc=borislav.petkov@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=norsk5@yahoo.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®