From: Joe Perches <joe@perches.com>
To: rklein@nvidia.com
Cc: jic23@cam.ac.uk, achew@nvidia.com, olof@lixom.net,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, ldewangan@nvidia.com
Subject: Re: [PATCH v2] iio: light: Adding driver for ISL29018 ALS
Date: Tue, 05 Oct 2010 14:35:17 -0700 [thread overview]
Message-ID: <1286314517.2156.50.camel@Joe-Laptop> (raw)
In-Reply-To: <1286313561-6456-1-git-send-email-rklein@nvidia.com>
On Tue, 2010-10-05 at 14:19 -0700, rklein@nvidia.com wrote:
> Adding support for the ISL 29018 ambient light and proximity sensor.
Trivial comments below.
> diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c
[]
> +static int isl29018_set_range(struct i2c_client *client, unsigned long range,
> + unsigned int *new_range)
> +{
> + unsigned long supp_ranges[] = {1000, 4000, 16000, 64000};
static const
> +static int isl29018_set_resolution(struct i2c_client *client,
> + unsigned long adcbit, unsigned int *conf_adc_bit)
> +{
> + unsigned long supp_adcbit[] = {16, 12, 8, 4};
here too
> +static int isl29018_chip_init(struct i2c_client *client)
> +{
> + struct isl29018_chip *chip = i2c_get_clientdata(client);
> + int status;
> + int i;
> + int new_adc_bit;
> + unsigned int new_range;
> +
> + for (i = 0; i < ARRAY_SIZE(chip->reg_cache); i++)
> + chip->reg_cache[i] = 0;
memset?
next prev parent reply other threads:[~2010-10-05 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-05 21:19 rklein
2010-10-05 21:35 ` Joe Perches [this message]
2010-10-05 21:36 ` Rhyland Klein
2010-10-05 21:41 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286314517.2156.50.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=achew@nvidia.com \
--cc=jic23@cam.ac.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rklein@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®