From: Roman Tereshonkov <roman.tereshonkov@nokia.com>
To: linux-kernel@vger.kernel.org
Cc: gregkh@suse.de, Roman Tereshonkov <roman.tereshonkov@nokia.com>
Subject: [PATCH] kobject: name reference should not be lost when lack of memory error happens
Date: Thu, 7 Oct 2010 13:32:53 +0300 [thread overview]
Message-ID: <1286447573-12579-1-git-send-email-roman.tereshonkov@nokia.com> (raw)
If lack of memory error happens we must restore the old kobject name reference
Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
---
lib/kobject.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/lib/kobject.c b/lib/kobject.c
index f07c572..c5cb117 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -222,8 +222,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
return 0;
kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
- if (!kobj->name)
+ if (!kobj->name) {
+ kobj->name = old_name;
return -ENOMEM;
+ }
/* ewww... some of these buggers have '/' in the name ... */
while ((s = strchr(kobj->name, '/')))
--
1.7.0.4
next reply other threads:[~2010-10-07 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 10:32 Roman Tereshonkov [this message]
2010-10-07 17:53 ` Greg KH
2010-10-09 14:32 ` Kay Sievers
2010-10-09 18:32 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286447573-12579-1-git-send-email-roman.tereshonkov@nokia.com \
--to=roman.tereshonkov@nokia.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®