mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robert Richter <robert.richter@amd.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
	oprofile-list <oprofile-list@lists.sourceforge.net>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	Robert Richter <robert.richter@amd.com>
Subject: [PATCH 4/7] oprofile, x86: Remove duplicate check for IBS_CAPS_OPCNT
Date: Fri, 8 Oct 2010 15:56:29 +0200	[thread overview]
Message-ID: <1286546192-18593-5-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <1286546192-18593-1-git-send-email-robert.richter@amd.com>

Since oprofile is setting up ibs_op/dispatched_ops in the fs only if
the feature is available, its corresponding variable
ibs_config.dispatched_ops is only set, if the feature is
available. Thus the check is duplicate and can be removed.

Signed-off-by: Robert Richter <robert.richter@amd.com>
---
 arch/x86/oprofile/op_model_amd.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/arch/x86/oprofile/op_model_amd.c b/arch/x86/oprofile/op_model_amd.c
index 96852d5..d5e9dab 100644
--- a/arch/x86/oprofile/op_model_amd.c
+++ b/arch/x86/oprofile/op_model_amd.c
@@ -257,8 +257,7 @@ static inline void op_amd_start_ibs(void)
 			ibs_op_ctl = min(ibs_op_ctl + IBS_RANDOM_MAXCNT_OFFSET,
 					 IBS_OP_MAX_CNT);
 		}
-		if (ibs_caps & IBS_CAPS_OPCNT && ibs_config.dispatched_ops)
-			ibs_op_ctl |= IBS_OP_CNT_CTL;
+		ibs_op_ctl |= ibs_config.dispatched_ops ? IBS_OP_CNT_CTL : 0;
 		ibs_op_ctl |= IBS_OP_ENABLE;
 		val = op_amd_randomize_ibs_op(ibs_op_ctl);
 		wrmsrl(MSR_AMD64_IBSOPCTL, val);
-- 
1.7.2.2



  parent reply	other threads:[~2010-10-08 14:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-08 13:56 [PATCH 0/7] oprofile, x86: updates for AMD family 12h and 14h systems Robert Richter
2010-10-08 13:56 ` [PATCH 1/7] oprofile, x86: Add support for AMD family 12h Robert Richter
2010-10-08 13:56 ` [PATCH 2/7] oprofile, x86: Add support for AMD family 14h Robert Richter
2010-10-08 13:56 ` [PATCH 3/7] oprofile, x86: Check IBS capability bits 1 and 2 Robert Richter
2010-10-08 13:56 ` Robert Richter [this message]
2010-10-08 13:56 ` [PATCH 5/7] oprofile, x86: Introduce struct ibs_state Robert Richter
2010-10-08 13:56 ` [PATCH 6/7] oprofile, x86: Add support for IBS branch target address reporting Robert Richter
2010-10-08 13:56 ` [PATCH 7/7] oprofile, x86: Add support for IBS periodic op counter extension Robert Richter
2010-10-15 13:55 ` [PATCH 0/7] oprofile, x86: updates for AMD family 12h and 14h systems Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1286546192-18593-5-git-send-email-robert.richter@amd.com \
    --to=robert.richter@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oprofile-list@lists.sourceforge.net \
    --cc=suravee.suthikulpanit@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome