From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932361Ab0JHQjV (ORCPT ); Fri, 8 Oct 2010 12:39:21 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54100 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932331Ab0JHQjU (ORCPT ); Fri, 8 Oct 2010 12:39:20 -0400 Subject: Re: PATCH 1/5] scsi: megaraid_sas - Add Online Controller Reset to MegaRAID SAS drive From: James Bottomley To: Tomas Henzl Cc: bo yang , linux-scsi@vger.kernel.org, akpm@osdl.org, linux-kernel@vger.kernel.org, bo.yang@lsi.com In-Reply-To: <4CAF3E04.1050304@redhat.com> References: <4CAF3E04.1050304@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 08 Oct 2010 11:39:14 -0500 Message-ID: <1286555954.2985.110.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.30.1.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-10-08 at 17:51 +0200, Tomas Henzl wrote: > On 09/23/2010 04:36 AM, bo yang wrote: > > This patch is too big. I am using attachment to submit. Please > > use attached file to apply. Also let me know if it can't be accepted. > > > > To add the Online controller reset support, driver need to do: > > a). reset the controller chips -- Xscale and Gen2 which will change > > the function calls and add the reset function related to this two > > chips. > > b). during the reset, driver will store the pending cmds which not > > returned by FW to driver's pending queue. Driver will re-issue those > > pending cmds again to FW after the OCR finished. > > c). In driver's timeout routine, driver will report to OS as reset. > > Also driver's queue routine will block the cmds until the OCR > > finished. > > d). in Driver's ISR routine, if driver get the FW state as state > > change, FW in Failure status and FW support online controller > > reset (OCR), driver will start to do the controller reset. > > e). In driver's IOCTL routine, the application cmds will wait for the > > OCR to finish, then issue the cmds to FW. > > > > Signed-off-by Bo Yang > > > > --- > > drivers/scsi/megaraid/megaraid_sas.c | 756 ++++++++++++++++++++++++++++++++--- > > drivers/scsi/megaraid/megaraid_sas.h | 88 +++- > > 2 files changed, 787 insertions(+), 57 deletions(-) > Hi Bo, > in the workqueue function you sleep for 30s, > it's scheduled here - schedule_work(&instance->work_init); > > +process_fw_state_change_wq(struct work_struct *work) > +{ > ... > + /*waitting for about 20 second before start the second init*/ > + for (wait = 0; wait < 30; wait++) { > + msleep(1000); > + } this lot should be ssleep(20) if you want a 20 sec sleep. > > - this is not a good practice to sleep for a so long time I think > - you should use in your exit function some synchronization > for example 'cancel_work_sync', without that if someone rmmods your > module, it could then lead to a memory corruption Actually flush_scheduled_work() should be fine ... it will force the module removal to wait for completion ... cancellation can be error prone, so just forcing the wait sounds easier. James