From: Nicolas Palix <npalix.work@gmail.com>
To: Randy Dunlap <rdunlap@xenotime.net>,
Nicolas Palix <npalix.work@gmail.com>,
Julia Lawall <julia@diku.dk>, Michal Marek <mmarek@suse.cz>,
Kulikov Vasiliy <segooon@gmail.com>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Sam Ravnborg <sam@ravnborg.org>,
Joerg Roedel <joerg.roedel@amd.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
cocci@diku.dk
Subject: [PATCH 3/6] Coccinelle: Improve user information with a new kind of comment
Date: Fri, 8 Oct 2010 21:27:38 +0200 [thread overview]
Message-ID: <1286566061-17122-4-git-send-email-npalix.work@gmail.com> (raw)
In-Reply-To: <1286566061-17122-1-git-send-email-npalix.work@gmail.com>
Improve user information with a new kind of comment
about semantic patch output.
Fix spelling.
Signed-off-by: Nicolas Palix <npalix.work@gmail.com>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
scripts/coccicheck | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index b8bcf1f..ef78c87 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -25,7 +25,7 @@ fi
if [ "$MODE" = "" ] ; then
if [ "$ONLINE" = "0" ] ; then
- echo 'You have not explicitly specify the mode to use. Fallback to "report".'
+ echo 'You have not explicitly specified the mode to use. Fallback to "report".'
echo 'You can specify the mode with "make coccicheck MODE=<mode>"'
echo 'Available modes are: report, patch, context, org'
fi
@@ -52,10 +52,12 @@ coccinelle () {
FILE=`echo $COCCI | sed "s|$srctree/||"`
- echo "Processing `basename $COCCI` with option(s) \"$OPT\""
+ echo "Processing `basename $COCCI`"
+ echo "with option(s) \"$OPT\""
+ echo ''
echo 'Message example to submit a patch:'
- sed -e '/\/\/\//!d' -e 's|^///||' $COCCI
+ sed -ne 's|^///||p' $COCCI
echo ' The semantic patch that makes this change is available'
echo " in $FILE."
@@ -64,6 +66,12 @@ coccinelle () {
echo ' http://coccinelle.lip6.fr/'
echo ''
+ if [ "`sed -ne 's|^//#||p' $COCCI`" ] ; then
+ echo 'Semantic patch information:'
+ sed -ne 's|^//#||p' $COCCI
+ echo ''
+ fi
+
$SPATCH -D $MODE $FLAGS -sp_file $COCCI $OPT -dir $srctree || exit 1
else
$SPATCH -D $MODE $FLAGS -sp_file $COCCI $OPT $OPTIONS || exit 1
--
1.7.0.4
next prev parent reply other threads:[~2010-10-08 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-08 19:27 [PATCH 0/6] Update coccinelle related files/information Nicolas Palix
2010-10-08 19:27 ` [PATCH 1/6] MAINTAINERS: Coccinelle: Update email address Nicolas Palix
2010-10-08 19:27 ` [PATCH 2/6] Coccinelle: Update documentation Nicolas Palix
2010-10-11 19:49 ` Randy Dunlap
2010-10-12 22:49 ` Nicolas Palix
2010-10-13 12:29 ` Michal Marek
2010-10-08 19:27 ` Nicolas Palix [this message]
2010-10-08 19:27 ` [PATCH 4/6] Coccinelle: Use new comment format to explain kfree.cocci Nicolas Palix
2010-10-08 19:27 ` [PATCH 5/6] Coccinelle: Add a new mode named 'chain' Nicolas Palix
2010-10-08 19:27 ` [PATCH 6/6] Coccinelle: Use the -no_show_diff option for org and report mode Nicolas Palix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286566061-17122-4-git-send-email-npalix.work@gmail.com \
--to=npalix.work@gmail.com \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@diku.dk \
--cc=joerg.roedel@amd.com \
--cc=julia@diku.dk \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rdunlap@xenotime.net \
--cc=sam@ravnborg.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome