From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757400Ab0JLNko (ORCPT ); Tue, 12 Oct 2010 09:40:44 -0400 Received: from e6.ny.us.ibm.com ([32.97.182.146]:33503 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757286Ab0JLNkl (ORCPT ); Tue, 12 Oct 2010 09:40:41 -0400 Subject: Re: [PATCH] security: move LSM xattrnames to xattr.h From: Mimi Zohar To: Steve Grubb Cc: Ozan =?UTF-8?Q?=C3=87a=C4=9Flayan?= , James Morris , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, Casey Schaufler , David Safford , Dave Hansen , Mimi Zohar In-Reply-To: <201010120919.11819.sgrubb@redhat.com> References: <1278011263-7951-1-git-send-email-zohar@linux.vnet.ibm.com> <201010121414.14486.ozan@pardus.org.tr> <1286888769.2670.5.camel@localhost.localdomain> <201010120919.11819.sgrubb@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 12 Oct 2010 09:40:34 -0400 Message-ID: <1286890834.2670.21.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 (2.30.3-1.fc13) Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2010-10-12 at 09:19 -0400, Steve Grubb wrote: > On Tuesday, October 12, 2010 09:06:09 am Mimi Zohar wrote: > > On Tue, 2010-10-12 at 14:14 +0300, Ozan Çağlayan wrote: > > > Cuma 02 Temmuz 2010 günü (saat 03:16:01) James Morris şunları yazmıştı: > > > > On Thu, 1 Jul 2010, Mimi Zohar wrote: > > > > > Make the security extended attributes names global. Updated to move > > > > > the remaining Smack xattrs. > > > > > > > > > > Signed-off-by: Mimi Zohar > > > > > Acked-by: Serge Hallyn > > > > > > This drops > > > > > > #define XATTR_CAPS_SUFFIX "capability" > > > #define XATTR_NAME_CAPS XATTR_SECURITY_PREFIX XATTR_CAPS_SUFFIX > > > > > > definitions from capability.h and puts them in xattr.h's #ifdef > > > __KERNEL__ section making them invisible to userspace like libcap-ng > > > causing build failures. > > > > > > Am I wrong? > > > > You're correct. It's the same reason that cap-ng.c has to define > > 'security'. > > > > #ifdef VFS_CAP_U32 > > #include > > #define XATTR_SECURITY_PREFIX "security." > > > > Am cc'ing Steve. > > So does this mean I need to provide more definitions for libcap-ng to work with > future kernels or are you asking my opinion? My opinion is that if user space > needs it to work correctly, please let it be available so I don't have to make > my own define which may be inaccurate one day. > > Thanks, > -Steve Before making any changes to the kernel xattr.h, I want to understand the reason for two xattr.h files, one in /usr/include/linux/ and the other in /usr/include/xattr/. /usr/include/linux/xattr.h contains those elements not defined as __kernel__, while /usr/include/xattr/xattr.h contains that and other definitions. Will changing the kernel xattr.h version change both? As long as we're making this change, should 'security' also be defined outside of the __kernel__ definitions? thanks, Mimi