From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755378Ab0JOAO0 (ORCPT ); Thu, 14 Oct 2010 20:14:26 -0400 Received: from ozlabs.org ([203.10.76.45]:59923 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073Ab0JOAOZ (ORCPT ); Thu, 14 Oct 2010 20:14:25 -0400 Subject: Re: [RFC PATCH] ppc: don't override CONFIG_PPC_PSERIES_DEBUG From: Michael Ellerman Reply-To: michael@ellerman.id.au To: Nishanth Aravamudan Cc: Michael Neuling , Frans Pop , linux-kernel@vger.kernel.org, Paul Mackerras , Anton Blanchard , Linas Vepstas , linuxppc-dev@lists.ozlabs.org, Thomas Gleixner In-Reply-To: <1287078495-11722-1-git-send-email-nacc@us.ibm.com> References: <1287078495-11722-1-git-send-email-nacc@us.ibm.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-c9/6FOcWQNQAeEXitdHD" Date: Fri, 15 Oct 2010 11:14:23 +1100 Message-ID: <1287101663.4194.5.camel@concordia> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-c9/6FOcWQNQAeEXitdHD Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2010-10-14 at 10:48 -0700, Nishanth Aravamudan wrote: > These files undef DEBUG, but I think they were added before the ability > to control this from Kconfig.=20 Perhaps. Some people, *cough*, have a tendency to merge those back in again from time to time :) > It's really annoying to only get some of the debug messages! True, but .. > Signed-off-by: Nishanth Aravamudan >=20 > --- > Because the lpar and pci_dlpar code is pretty low-level & verbose, > perhaps it makes sense to add another Kconfig variable for really > low-level stuff? But it's annoying to have DEBUG *somewhat* effective, > especially in the EEH area when doing PCI stuff. I really don't think you want to enable the lpar debug by default. Have you tried it? It can make for a pretty unusable system, just because of the console spam. Also these days there is CONFIG_DYNAMIC_DEBUG which is much smarter than all this, but requires setup at runtime. cheers --=-c9/6FOcWQNQAeEXitdHD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAky3nNwACgkQdSjSd0sB4dLpcgCgyIHkaqdl+HA3iyvu+1EQ7qkk bNwAn3gAE1UJk1EmtgirjzaDTcUNJkRt =mpvj -----END PGP SIGNATURE----- --=-c9/6FOcWQNQAeEXitdHD--