From: Steven Rostedt <rostedt@goodmis.org>
To: Jason Baron <jbaron@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 0/9] [GIT PULL] tracing: updates for 2.6.37
Date: Fri, 15 Oct 2010 22:03:29 -0400 [thread overview]
Message-ID: <1287194609.16971.37.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20101013214614.GC2878@redhat.com>
On Wed, 2010-10-13 at 17:46 -0400, Jason Baron wrote:
> On Fri, Oct 08, 2010 at 11:59:47PM -0400, Steven Rostedt wrote:
> > On Fri, 2010-10-08 at 10:45 +0200, Ingo Molnar wrote:
> > > hm, i'm getting:
> > >
> > > arch/x86/kernel/alternative.c: Assembler messages:
> > > arch/x86/kernel/alternative.c:674: Error: symbol `ftrace_test_jmp' is already defined
> > > arch/x86/kernel/alternative.c:678: Error: symbol `ftrace_test_p6nop' is already defined
> > > arch/x86/kernel/alternative.c:680: Error: symbol `ftrace_test_nop5' is already defined
> > >
> > > Config attached.
> >
> > I'll see if I can get to this early next week. I'll be leaving to NYC on
> > Monday for the End Users Summit. I'll try to look at this while there.
> >
> > Thanks!
> >
> > -- Steve
> >
>
> just saw this...looks like this is broken for gcc < 4.5. Anyways, the
> patch below fixes the compilation by making arch_init_ideal_nop5()
> static (and moving its definition ahead of its usage). I'm not quite
> sure why this makes the compiler happy...applies on top of this series.
>
I can't reproduce this. And I don't like patches that have comments
like: "not quite sure why this makes the compiler happy".
Is this still an issue? I tried out gcc 4.4.2, 4.4.4 and gcc 4.5.1 with
the config given, and did not get the above errors.
-- Steve
prev parent reply other threads:[~2010-10-16 2:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-06 3:34 Steven Rostedt
2010-10-06 3:34 ` [PATCH 1/9] tracing/trivial: Remove cast from void* Steven Rostedt
2010-10-06 3:34 ` [PATCH 2/9] jump label/x86: Move arch_init_ideal_nop5 later Steven Rostedt
2010-10-06 3:34 ` [PATCH 3/9] tracing/x86: No need to disable interrupts when calling arch_init_ideal_nop5 Steven Rostedt
2010-10-06 3:34 ` [PATCH 4/9] tracing: Add proper check for irq_depth routines Steven Rostedt
2010-10-06 3:34 ` [PATCH 5/9] tracing: Make graph related irqs/preemptsoff functions global Steven Rostedt
2010-10-06 3:34 ` [PATCH 6/9] tracing: Graph support for wakeup tracer Steven Rostedt
2010-10-06 3:34 ` [PATCH 7/9] tracing: Use one prologue for the wakeup tracer function tracers Steven Rostedt
2010-10-06 3:34 ` [PATCH 8/9] tracing: Use one prologue for the preempt irqs off " Steven Rostedt
2010-10-06 3:34 ` [PATCH 9/9] tracing: Remove parent recording in latency tracer graph options Steven Rostedt
2010-10-08 8:16 ` [PATCH 0/9] [GIT PULL] tracing: updates for 2.6.37 Ingo Molnar
2010-10-08 8:45 ` Ingo Molnar
2010-10-09 3:59 ` Steven Rostedt
2010-10-13 21:46 ` Jason Baron
2010-10-16 2:03 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287194609.16971.37.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®