From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757343Ab0JQOlh (ORCPT ); Sun, 17 Oct 2010 10:41:37 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:61194 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757262Ab0JQOla (ORCPT ); Sun, 17 Oct 2010 10:41:30 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=ZWnct0Jad/hK7X6h8Inz8r7ofgMYRf7hjmT+akg+9b8pKizyXYEJ2aSMYoZlYQ0eSL 0Ewitg3lZVolR8Ns0zNCVa1MWqzav3dMZOfsxcmf9mFPJFaQFPFLFQg9mzud51VWgtth OttFPRCsQMaC9Zg4C7vrBEPflqs4oQxeesBX0= From: Vasiliy Kulikov To: kernel-janitors@vger.kernel.org Cc: Dominik Brodowski , "Gustavo F. Padovan" , Marcel Holtmann , Greg Kroah-Hartman , "David S. Miller" , linux-kernel@vger.kernel.org Subject: [PATCH 4/8] char: pcmcia: synclink_cs: fix information leak to userland Date: Sun, 17 Oct 2010 18:41:24 +0400 Message-Id: <1287326485-8028-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Structure new_line is copied to userland with some padding fields unitialized. It leads to leaking of stack memory. Signed-off-by: Vasiliy Kulikov --- Compile tested. drivers/char/pcmcia/synclink_cs.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c index db9efbe..bfc10f8 100644 --- a/drivers/char/pcmcia/synclink_cs.c +++ b/drivers/char/pcmcia/synclink_cs.c @@ -4091,6 +4091,8 @@ static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd) if (cmd != SIOCWANDEV) return hdlc_ioctl(dev, ifr, cmd); + memset(&new_line, 0, size); + switch(ifr->ifr_settings.type) { case IF_GET_IFACE: /* return current sync_serial_settings */ -- 1.7.0.4