mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: khali@linux-fr.org, linux-i2c@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	device-drivers-devel@blackfin.uclinux.org,
	Michael Hennerich <michael.hennerich@analog.com>
Subject: [PATCH] i2c: add irq_flags to board info
Date: Sun, 17 Oct 2010 19:43:39 -0400	[thread overview]
Message-ID: <1287359019-1476-1-git-send-email-vapier@gentoo.org> (raw)

From: Michael Hennerich <michael.hennerich@analog.com>

These flags can be optionally defined - slave drivers may use them as
flags argument for request_irq().  In case they are left uninitialized
they will default to zero, and therefore shouldn't cause problems.

This allows us to avoid having to add dedicated platform init code just
to call set_irq_type() -- which doesn't work very well when coupled with
module drivers.  It also matches behavior of some other frameworks like
IDE and UIO.

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 drivers/i2c/i2c-core.c |    1 +
 include/linux/i2c.h    |    4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index bea4c50..830528f 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -540,6 +540,7 @@ i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)
 	client->flags = info->flags;
 	client->addr = info->addr;
 	client->irq = info->irq;
+	client->irq_flags = info->irq_flags;
 
 	strlcpy(client->name, info->type, sizeof(client->name));
 
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 4bae0b7..e6248c1 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -189,6 +189,7 @@ struct i2c_driver {
  * @driver: device's driver, hence pointer to access routines
  * @dev: Driver model device node for the slave.
  * @irq: indicates the IRQ generated by this device (if any)
+ * @irq_flags: The flags passed to request_irq()
  * @detected: member of an i2c_driver.clients list or i2c-core's
  *	userspace_devices list
  *
@@ -206,6 +207,7 @@ struct i2c_client {
 	struct i2c_driver *driver;	/* and our access routines	*/
 	struct device dev;		/* the device structure		*/
 	int irq;			/* irq issued by device		*/
+	unsigned long irq_flags;	/* flags used by the irq 	*/
 	struct list_head detected;
 };
 #define to_i2c_client(d) container_of(d, struct i2c_client, dev)
@@ -237,6 +239,7 @@ static inline void i2c_set_clientdata(struct i2c_client *dev, void *data)
  * @archdata: copied into i2c_client.dev.archdata
  * @of_node: pointer to OpenFirmware device node
  * @irq: stored in i2c_client.irq
+ * @irq_flags: The flags passed to request_irq() for i2c_client.irq
  *
  * I2C doesn't actually support hardware probing, although controllers and
  * devices may be able to use I2C_SMBUS_QUICK to tell whether or not there's
@@ -259,6 +262,7 @@ struct i2c_board_info {
 	struct device_node *of_node;
 #endif
 	int		irq;
+	unsigned long	irq_flags;
 };
 
 /**
-- 
1.7.3.1


             reply	other threads:[~2010-10-17 23:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-17 23:43 Mike Frysinger [this message]
2010-10-18  8:36 ` Jean Delvare
2010-10-18  9:55   ` Hennerich, Michael
2010-10-18 12:01     ` Jean Delvare
2010-10-18 12:31       ` Hennerich, Michael
2010-10-18 14:33         ` Jean Delvare
2010-10-18 15:38           ` David Brownell
2010-10-18 15:46           ` Hennerich, Michael
2010-10-18 19:51           ` [Device-drivers-devel] " Mike Frysinger
2010-10-25  0:45             ` Ben Dooks
2010-10-25 14:12               ` Jonathan Cameron
2011-01-07  1:33               ` Mike Frysinger
2010-10-20 18:59   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287359019-1476-1-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=khali@linux-fr.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®