Re: [PATCH 0/6] Results of my work on memorystick subsystem

[Maxim Levitsky <maximlevitsky@gmail.com>]

On Mon, 2010-10-18 at 00:05 -0700, Alex Dubov wrote:
> --- On Sun, 17/10/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> 
> > > 
> > > Here is a result of lot of work I did improving the
> > memorystick
> > > subsystem and its drivers.
> > Comments?
> > Flames?
> > Suggestions?
> > 
> 
> My opinion is, that in the current form your patches are completely
> unworkable.
> 
> I suggest a following approach, consisting of 3 clearly separated steps:
> 
> Step 1 - a set of functional patches to jmicron driver.
> Step 2 - a set of functional patches to mspro driver.
> Step 3 - common code elimination (the whole thing is not that large, it
> can tolerate some code duplication).
> 
> When we done with this, we can discuss whatever cosmetic changes you want
> to do (moving stuff around and , possibly, renaming, which I don't see as
> necessary at all).
Alex,
In jmicron driver I did move functions around and renamed them.
I am not against doing that in separate patch.

But for mspro driver, it would be really hard for me to split it.
I have rewritten a lot of code there.
Can't we just review the end result instead of the patch?

To split the patches, I pretty much need to rewrite the whole thing once
gain.
I don't want to do that.

Best regards,
	Maxim Levitsky