From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756770Ab0JSW45 (ORCPT ); Tue, 19 Oct 2010 18:56:57 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:35900 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756007Ab0JSW44 (ORCPT ); Tue, 19 Oct 2010 18:56:56 -0400 X-Authority-Analysis: v=1.1 cv=6ptpMFIBtxRk0xdOb6IhJTbTLVRlKjWFes7R4SsWCrA= c=1 sm=0 a=wGm5nfgfXM4A:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=S3LCjarNi3WNL6e033AA:9 a=yLvTSRubY_N9kOUKoGgA:7 a=dMH_MHFN8JUL1nYNAAjTgLtWKhoA:4 a=PUjeQqilurYA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: [PATCH] tracing: Cleanup the convoluted softirq tracepoints From: Steven Rostedt To: "H. Peter Anvin" Cc: Jason Baron , Thomas Gleixner , Mathieu Desnoyers , Koki Sanagi , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , nhorman@tuxdriver.com, scott.a.mcmillan@intel.com, laijs@cn.fujitsu.com, LKML , eric.dumazet@gmail.com, kaneshige.kenji@jp.fujitsu.com, David Miller , izumi.taku@jp.fujitsu.com, kosaki.motohiro@jp.fujitsu.com, Heiko Carstens , "Luck, Tony" In-Reply-To: <4CBE1F5E.8040807@zytor.com> References: <4CBD79CF.2060706@jp.fujitsu.com> <20101019132236.GA19197@Krystal> <1287496495.16971.372.camel@gandalf.stny.rr.com> <20101019142820.GA14520@Krystal> <20101019212816.GA2855@redhat.com> <20101019223842.GE2855@redhat.com> <4CBE1F5E.8040807@zytor.com> Content-Type: text/plain; charset="ISO-8859-15" Date: Tue, 19 Oct 2010 18:56:53 -0400 Message-ID: <1287529013.16971.537.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2010-10-19 at 15:44 -0700, H. Peter Anvin wrote: > On 10/19/2010 03:38 PM, Jason Baron wrote: > > > > I'm not sure I did, the documentation says that we have nop followed by > > a jmp: > > > > +The new code is a 'nopl' followed by a 'jmp'. Thus: > > + > > +nopl - 0f 1f 44 00 00 - 5 bytes > > +jmp - eb 3e - 2 bytes > > > > There is no excuse for needing the second jump here, obviously... Now the trick is to tell gcc that. -- Steve