From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754851Ab0JVHXo (ORCPT ); Fri, 22 Oct 2010 03:23:44 -0400 Received: from statler.bytemark.co.uk ([212.110.162.18]:44923 "EHLO statler.bytemark.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754645Ab0JVHXn (ORCPT ); Fri, 22 Oct 2010 03:23:43 -0400 From: "Emilio G. Cota" To: Greg KH Cc: Martyn Welch , LKML , Juan David Gonzalez Cobas Subject: [PATCH 06/30] staging/vme/tsi148: use list_for_each_safe when deleting resources in .remove Date: Fri, 22 Oct 2010 02:36:28 -0400 Message-Id: <1287729412-24356-7-git-send-email-cota@braap.org> X-Mailer: git-send-email 1.7.3.1 In-Reply-To: <1287729412-24356-1-git-send-email-cota@braap.org> References: <1287729412-24356-1-git-send-email-cota@braap.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Emilio G. Cota This fixes an oops when removing the module. Signed-off-by: Emilio G. Cota --- drivers/staging/vme/bridges/vme_tsi148.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c index e341122..660968e 100644 --- a/drivers/staging/vme/bridges/vme_tsi148.c +++ b/drivers/staging/vme/bridges/vme_tsi148.c @@ -2532,6 +2532,7 @@ err_struct: static void tsi148_remove(struct pci_dev *pdev) { struct list_head *pos = NULL; + struct list_head *tmplist; struct vme_master_resource *master_image; struct vme_slave_resource *slave_image; struct vme_dma_resource *dma_ctrlr; @@ -2590,21 +2591,21 @@ static void tsi148_remove(struct pci_dev *pdev) tsi148_crcsr_exit(tsi148_bridge, pdev); /* resources are stored in link list */ - list_for_each(pos, &tsi148_bridge->dma_resources) { + list_for_each_safe(pos, tmplist, &tsi148_bridge->dma_resources) { dma_ctrlr = list_entry(pos, struct vme_dma_resource, list); list_del(pos); kfree(dma_ctrlr); } /* resources are stored in link list */ - list_for_each(pos, &tsi148_bridge->slave_resources) { + list_for_each_safe(pos, tmplist, &tsi148_bridge->slave_resources) { slave_image = list_entry(pos, struct vme_slave_resource, list); list_del(pos); kfree(slave_image); } /* resources are stored in link list */ - list_for_each(pos, &tsi148_bridge->master_resources) { + list_for_each_safe(pos, tmplist, &tsi148_bridge->master_resources) { master_image = list_entry(pos, struct vme_master_resource, list); list_del(pos); -- 1.7.1