From: Eric Dumazet <eric.dumazet@gmail.com>
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>,
Jens Axboe <jaxboe@fusionio.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [BUG] disk_free_ptbl_rcu_cb() crash
Date: Sat, 23 Oct 2010 23:10:01 +0200 [thread overview]
Message-ID: <1287868201.2658.563.camel@edumazet-laptop> (raw)
Current Linus tree makes my machine crash in disk_free_ptbl_rcu_cb(),
while booting...
commit 7681bfeeccff5ef seems the problem ?
Following patch solves the NULL dereference, but this is only to show
you where the problem is, not a real fix, of course.
Thanks
block/genhd.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/block/genhd.c b/block/genhd.c
index a8adf96..b63d401 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -930,14 +930,16 @@ static void disk_free_ptbl_rcu_cb(struct rcu_head *head)
struct disk_part_tbl *ptbl =
container_of(head, struct disk_part_tbl, rcu_head);
struct gendisk *disk = ptbl->disk;
- struct request_queue *q = disk->queue;
+ struct request_queue *q = disk ? disk->queue : NULL;
unsigned long flags;
kfree(ptbl);
- spin_lock_irqsave(q->queue_lock, flags);
- elv_quiesce_end(q);
- spin_unlock_irqrestore(q->queue_lock, flags);
+ if (q) {
+ spin_lock_irqsave(q->queue_lock, flags);
+ elv_quiesce_end(q);
+ spin_unlock_irqrestore(q->queue_lock, flags);
+ }
}
/**
next reply other threads:[~2010-10-23 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-23 21:10 Eric Dumazet [this message]
2010-10-24 6:04 ` Jens Axboe
2010-10-24 6:44 ` Eric Dumazet
2010-10-24 6:45 ` Jens Axboe
2010-10-24 6:52 ` Vivek Goyal
2010-10-24 7:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287868201.2658.563.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®