From: Namhyung Kim <namhyung@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h
Date: Tue, 26 Oct 2010 00:52:36 +0900 [thread overview]
Message-ID: <1288021958-3130-1-git-send-email-namhyung@gmail.com> (raw)
It seems that #include <asm/system.h> makes a circular dependency
between kernel.h and bitmap.h which breaks allmodconfig build.
Removing the line makes no change because jump_label.h doesn't
need it actually AFAICS. Compile tested on sparc32 allmodconfig.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
Failed build log is as following:
CC arch/sparc/kernel/asm-offsets.s
In file included from include/linux/cpumask.h:11:0,
from arch/sparc/include/asm/smp_32.h:15,
from arch/sparc/include/asm/smp.h:6,
from arch/sparc/include/asm/system_32.h:12,
from arch/sparc/include/asm/system.h:6,
from arch/sparc/include/asm/jump_label.h:7,
from include/linux/jump_label.h:5,
from include/linux/dynamic_debug.h:4,
from include/linux/kernel.h:20,
from include/linux/sched.h:54,
from arch/sparc/kernel/asm-offsets.c:13:
include/linux/bitmap.h: In function 'bitmap_zero':
include/linux/bitmap.h:159:3: error: implicit declaration of function 'DIV_ROUND_UP'
In file included from arch/sparc/include/asm/smp_32.h:15:0,
from arch/sparc/include/asm/smp.h:6,
from arch/sparc/include/asm/system_32.h:12,
from arch/sparc/include/asm/system.h:6,
from arch/sparc/include/asm/jump_label.h:7,
from include/linux/jump_label.h:5,
from include/linux/dynamic_debug.h:4,
from include/linux/kernel.h:20,
from include/linux/sched.h:54,
from arch/sparc/kernel/asm-offsets.c:13:
include/linux/cpumask.h: At top level:
include/linux/cpumask.h:13:26: error: variably modified 'bits' at file scope
include/linux/cpumask.h:659:14: error: variably modified 'cpu_all_bits' at file scope
include/linux/cpumask.h:705:2: error: variably modified 'cpu_bit_bitmap' at file scope
make[3]: *** [arch/sparc/kernel/asm-offsets.s] Error 1
make[2]: *** [prepare0] Error 2
make[1]: *** [sub-make] Error 2
make: *** [all] Error 2
arch/sparc/include/asm/jump_label.h | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/sparc/include/asm/jump_label.h b/arch/sparc/include/asm/jump_label.h
index 62e66d7..65c0d30 100644
--- a/arch/sparc/include/asm/jump_label.h
+++ b/arch/sparc/include/asm/jump_label.h
@@ -4,7 +4,6 @@
#ifdef __KERNEL__
#include <linux/types.h>
-#include <asm/system.h>
#define JUMP_LABEL_NOP_SIZE 4
--
1.7.0.4
next reply other threads:[~2010-10-25 15:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 15:52 Namhyung Kim [this message]
2010-10-25 15:52 ` [PATCH 2/3] sparc32: remove CONFIG_HAVE_PERF_EVENTS option Namhyung Kim
2010-10-25 15:59 ` David Miller
2010-10-25 16:31 ` Namhyung Kim
2010-10-25 18:55 ` David Miller
2010-10-25 15:52 ` [PATCH 3/3] sparc32: fix build failure on CONFIG_SPARC_LEON Namhyung Kim
2010-10-25 16:00 ` David Miller
2010-10-25 16:07 ` Namhyung Kim
2010-10-25 16:09 ` David Miller
2010-10-25 16:11 ` Sam Ravnborg
2010-10-25 18:53 ` David Miller
2010-10-25 19:41 ` Sam Ravnborg
2010-10-26 7:14 ` Daniel Hellstrom
2010-10-25 15:57 ` [PATCH 1/3] sparc: don't #include asm/system.h in asm/jump_label.h David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288021958-3130-1-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®