mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Venkatesh Pallipadi <venki@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Balbir Singh <balbir@linux.vnet.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, Paul Turner <pjt@google.com>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Shaun Ruffell <sruffell@digium.com>,
	Yong Zhang <yong.zhang0@gmail.com>,
	Venkatesh Pallipadi <venki@google.com>
Subject: [PATCH 6/6] Account ksoftirqd time as cpustat softirq -v1
Date: Mon, 25 Oct 2010 15:30:17 -0700	[thread overview]
Message-ID: <1288045817-3135-7-git-send-email-venki@google.com> (raw)
In-Reply-To: <1288045817-3135-1-git-send-email-venki@google.com>

softirq time in ksoftirqd context is not accounted in ns granularity
per cpu softirq stats, as we want that to be a part of ksoftirqd
exec_runtime.

Accounting them as softirq on /proc/stat separately.

Tested-by: Shaun Ruffell <sruffell@digium.com>

Signed-off-by: Venkatesh Pallipadi <venki@google.com>
---
 kernel/sched.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/kernel/sched.c b/kernel/sched.c
index 49f6f61..0955050 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -3617,6 +3617,14 @@ static void irqtime_account_process_tick(struct task_struct *p, int user_tick,
 		cpustat->irq = cputime64_add(cpustat->irq, tmp);
 	} else if (irqtime_account_si_update()) {
 		cpustat->softirq = cputime64_add(cpustat->softirq, tmp);
+	} else if (this_cpu_ksoftirqd() == p) {
+		/*
+		 * ksoftirqd time do not get accounted in cpu_softirq_time.
+		 * So, we have to handle it separately here.
+		 * Also, p->stime needs to be updated for ksoftirqd.
+		 */
+		__account_system_time(p, cputime_one_jiffy, one_jiffy_scaled,
+					&cpustat->softirq);
 	} else if (user_tick) {
 		account_user_time(p, cputime_one_jiffy, one_jiffy_scaled);
 	} else if (p == rq->idle) {
-- 
1.7.1


  parent reply	other threads:[~2010-10-25 22:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25 22:30 [PATCH 0/6] Proper kernel irq time reporting -v1 Venkatesh Pallipadi
2010-10-25 22:30 ` [PATCH 1/6] Free up pf flag PF_KSOFTIRQD -v1 Venkatesh Pallipadi
2010-10-25 22:30 ` [PATCH 2/6] cleanup account_system_vtime with this_cpu_* -v1 Venkatesh Pallipadi
2010-10-25 22:30 ` [PATCH 3/6] Add nsecs_to_cputime64 interface for asm-generic -v1 Venkatesh Pallipadi
2010-10-25 22:30 ` [PATCH 4/6] Refactor account_system_time separating id-update -v1 Venkatesh Pallipadi
2010-10-25 22:30 ` [PATCH 5/6] Export ns irqtimes through /proc/stat -v1 Venkatesh Pallipadi
2010-10-26  9:45   ` Peter Zijlstra
2010-10-26 14:57     ` Peter Zijlstra
2010-10-26 17:35       ` Venkatesh Pallipadi
2010-10-25 22:30 ` Venkatesh Pallipadi [this message]
2010-10-26  9:33   ` [PATCH 6/6] Account ksoftirqd time as cpustat softirq -v1 Peter Zijlstra
2010-10-26  9:50     ` Peter Zijlstra
2010-10-26 17:35       ` Venkatesh Pallipadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288045817-3135-7-git-send-email-venki@google.com \
    --to=venki@google.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=pjt@google.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=sruffell@digium.com \
    --cc=tglx@linutronix.de \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®