From: Julia Lawall <julia@diku.dk>
To: Brett Rudley <brudley@broadcom.com>
Cc: kernel-janitors@vger.kernel.org,
Henry Ptasinski <henryp@broadcom.com>,
Nohee Ko <noheek@broadcom.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/14] drivers/staging/brcm80211/brcmfmac/dhd_linux.c: delete double assignment
Date: Tue, 26 Oct 2010 12:25:33 +0200 [thread overview]
Message-ID: <1288088743-3725-5-git-send-email-julia@diku.dk> (raw)
In-Reply-To: <1288088743-3725-1-git-send-email-julia@diku.dk>
From: Julia Lawall <julia@diku.dk>
Delete successive assignments to the same location. dhd_ops_virt contains
a subset of the definitions of dhd_ops_pri.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression i;
@@
*i = ...;
i = ...;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
index e535787..30b8e9b 100644
--- a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
+++ b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c
@@ -2222,8 +2222,6 @@ int dhd_net_attach(dhd_pub_t *dhdp, int ifidx)
ASSERT(net);
ASSERT(!net->netdev_ops);
- net->netdev_ops = &dhd_ops_virt;
-
net->netdev_ops = &dhd_ops_pri;
/*
next prev parent reply other threads:[~2010-10-26 10:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 10:25 [PATCH 0/14] " Julia Lawall
2010-10-26 10:25 ` [PATCH 1/14] drivers/staging: " Julia Lawall
2010-10-26 10:25 ` [PATCH 2/14] drivers/usb/gadget/amd5536udc.c: " Julia Lawall
2010-10-26 13:43 ` Thomas Dahlmann
2010-10-26 10:25 ` [PATCH 3/14] drivers/vhost/vhost.c: " Julia Lawall
2010-10-26 11:06 ` Michael S. Tsirkin
2010-10-26 10:25 ` Julia Lawall [this message]
2010-10-26 10:25 ` [PATCH 5/14] drivers/net/sb1000.c: " Julia Lawall
2010-10-26 11:58 ` walter harms
2010-10-26 12:25 ` Julia Lawall
2010-10-27 19:23 ` David Miller
2010-10-26 10:25 ` [PATCH 6/14] arch/mips/pmc-sierra/yosemite/setup.c: " Julia Lawall
2010-11-09 0:48 ` Ralf Baechle
2010-11-09 7:10 ` Julia Lawall
2010-10-26 10:25 ` [PATCH 7/14] drivers/net/typhoon.c: " Julia Lawall
2010-10-26 11:52 ` David Dillow
2010-10-27 19:24 ` David Miller
2010-10-26 10:25 ` [PATCH 8/14] drivers/platform/x86/thinkpad_acpi.c: " Julia Lawall
2010-10-27 1:09 ` Henrique de Moraes Holschuh
2010-10-27 1:24 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2010-10-27 3:54 ` Dan Carpenter
2010-10-27 21:42 ` Henrique de Moraes Holschuh
2010-10-27 5:03 ` Julia Lawall
2010-10-27 7:18 ` walter harms
2010-10-27 8:11 ` Dan Carpenter
2010-11-24 16:51 ` Matthew Garrett
2010-10-26 10:25 ` [PATCH 9/14] sound/oss/sb_ess.c: " Julia Lawall
2010-10-27 7:13 ` Takashi Iwai
2010-10-26 10:25 ` [PATCH 10/14] drivers/isdn: " Julia Lawall
2010-10-26 11:55 ` walter harms
2010-10-26 12:01 ` Julia Lawall
2010-10-26 12:20 ` Julia Lawall
2010-10-27 19:24 ` David Miller
2010-10-26 10:25 ` [PATCH 11/14] drivers/serial/vr41xx_siu.c: " Julia Lawall
2010-10-26 10:25 ` [PATCH 12/14] drivers/video/omap/blizzard.c: " Julia Lawall
2010-10-26 12:36 ` Nicolas Kaiser
2010-10-26 10:25 ` [PATCH 13/14] drivers/scsi/be2iscsi/be_main.c: " Julia Lawall
2010-10-26 10:25 ` [PATCH 14/14] drivers/ata/pata_octeon_cf.c: " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288088743-3725-5-git-send-email-julia@diku.dk \
--to=julia@diku.dk \
--cc=brudley@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=henryp@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=noheek@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®