From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
rusty@rustcorp.com.au, fweisbec@gmail.com, srostedt@redhat.com,
tglx@linutronix.de, Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [tip:perf/urgent] tracing: Prevent unloadable modules from using trace_bprintk()
Date: Tue, 26 Oct 2010 11:21:33 -0400 [thread overview]
Message-ID: <1288106493.18238.82.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <AANLkTin7Daj=HnWXstuWxymjuBfF9axfKZWvei_EKefw@mail.gmail.com>
On Tue, 2010-10-26 at 08:06 -0700, Linus Torvalds wrote:
> On Tue, Oct 26, 2010 at 3:21 AM, tip-bot for Steven Rostedt
> <srostedt@redhat.com> wrote:
> >
> > tracing: Prevent unloadable modules from using trace_bprintk()
>
> I still don't think this patch makes sense.
>
> Some of it is just totally insane. The CONFIG_MODVERSIONS check is
> just crazy. MODVERSIONS has nothing what-so-ever to do with the issue.
>
> Don't do this. It's total voodoo programming.
Yeah, I think Ingo pulled this by mistake (I asked him to do some pull
requests, and this was probably mixed in the real ones). I purposely
pulled it out of my other pull requests so we could debate it more.
The right answer is what Li Zefan said and that is to simply flush the
ring buffer on module removal if the module uses a trace_bprintk(). We
already do this for tracepoints.
-- Steve
next prev parent reply other threads:[~2010-10-26 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-c3b87c579e5df72a59fe97d77d4c3791dc8154ec@git.kernel.org>
2010-10-26 15:06 ` Linus Torvalds
2010-10-26 15:21 ` Steven Rostedt [this message]
2010-10-26 17:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288106493.18238.82.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®