From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org,
davem@davemloft.net, holt@sgi.com, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [patch 116/176] fs: allow for more than 2^31 files
Date: Wed, 27 Oct 2010 14:46:02 +0200 [thread overview]
Message-ID: <1288183562.2709.94.camel@edumazet-laptop> (raw)
In-Reply-To: <20101027115946.GA26335@lst.de>
Le mercredi 27 octobre 2010 à 13:59 +0200, Christoph Hellwig a écrit :
> This patch breaks the binary sysctl ABI. It probably doesn't matter
> as no one actually used it, but it might be better idea to just remove
> this node from the binary sysctl tree.
>
Good point
To be precise, sysctl() truncates the value to low order 32bit value,
because it internally uses simple_strtoul(), then a put_user()
An old binary using sysctl() to fetch FS_MAXFILE could break on SGI
machines. I am not sure we should remove sysctl FS_MAXFILE because of
this rare case.
prev parent reply other threads:[~2010-10-27 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201010262122.o9QLMiZG016728@imap1.linux-foundation.org>
2010-10-27 11:59 ` Christoph Hellwig
2010-10-27 12:46 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288183562.2709.94.camel@edumazet-laptop \
--to=eric.dumazet@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®