From: Steven Rostedt <rostedt@goodmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: fix TRACE_EVENT power tracepoint creation
Date: Thu, 28 Oct 2010 08:53:44 -0400 [thread overview]
Message-ID: <1288270424.18238.211.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20101028110321.GA24711@Krystal>
On Thu, 2010-10-28 at 07:03 -0400, Mathieu Desnoyers wrote:
> Given that trace/power.h is inluded in more than one .c file, generating
> DEFINE_TRACE() when CREATE_TRACE_POINTS is not set does not work. So what
> alternative do you suggest ?
Right, DEFINE_TRACE should only be set when CREATE_TRACE_POINTS is set,
and that is only set in the C file that the DEFINE_TRACE is to be
defined.
In fact, I don't even see what bug you are trying to fix?
The file include/trace/define_trace.h converts all the TRACE_EVENTS()
into DEFINE_TRACE() when CREATE_TRACE_POINTS is set. No other C file
that includes power.h should have CREATE_TRACE_POINTS set. I guess if it
did, the CONFIG_EVENT_TRACING would break too.
It should just work.
-- Steve
next prev parent reply other threads:[~2010-10-28 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 2:16 Mathieu Desnoyers
2010-10-28 2:25 ` Steven Rostedt
2010-10-28 11:03 ` Mathieu Desnoyers
2010-10-28 12:53 ` Steven Rostedt [this message]
2010-10-28 13:17 ` Mathieu Desnoyers
2010-10-28 14:33 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288270424.18238.211.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®