mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: member graysky <graysky@archlinux.us>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: bug in streamline_config.pl
Date: Thu, 28 Oct 2010 10:03:05 -0400	[thread overview]
Message-ID: <1288274585.18238.241.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <AANLkTik5RRYFgBC2oY-9EYWRh7Q72SqhRB4m_2w5Oia4@mail.gmail.com>

OK, you just found a bug ;-)

You complained about CONFIG_DRM_RADEON being selected (that's ATI
Radean). Here's why:

CONFIG_DRM_RADEON select by dependency on HWMON
CONFIG_HWMON_VID selected by direct module hwmon_vid

You had hwmon_vid enabled. This module gets selected by other modules,
one being DRM_RADEON.

If a module is selected by other modules and does not have a prompt to
select itself, then I have to select the other modules because I don't
know what module is needed to make sure this module is selected (again,
I can add logic to see if the select is satisfied by the direct
selections).

But, (here's the bug) HWMON has a prompt!  But it's a different kind of
prompt. It's a menuconfig option and not a config option. By making this
one-liner fix, I just removed the following options from your config:

 CONFIG_HOTPLUG_PCI=m
 CONFIG_RFKILL=m
 CONFIG_SFC=m
 CONFIG_DRM=m
 CONFIG_DRM_KMS_HELPER=m
 CONFIG_DRM_RADEON=m
 CONFIG_DRM_I915=m
 CONFIG_FB_DDC=m
 CONFIG_FB_NVIDIA=m
 CONFIG_FB_RIVA=m
 CONFIG_FB_RADEON=m
 CONFIG_FB_SAVAGE=m
 CONFIG_FB_3DFX=m
 CONFIG_DRM_NOUVEAU=m
 CONFIG_THINKPAD_ACPI=m
 CONFIG_EEEPC_LAPTOP=m

I'll go ahead and make sure that this fix makes it into 2.6.37

-- Steve




      parent reply	other threads:[~2010-10-28 14:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTikHTu=MsoYu=PPxAh7t6oGPKnp=FybNMPXkMSx3@mail.gmail.com>
     [not found] ` <1288013006.18238.0.camel@gandalf.stny.rr.com>
     [not found]   ` <AANLkTikdVu4k21K0G9C8vZ54=yGiBFKpGxdPaZM9cEPv@mail.gmail.com>
2010-10-25 21:14     ` Steven Rostedt
     [not found]       ` <AANLkTimgsbFWz34m52+=bgYiccCMc3acSE40qDhCM2tx@mail.gmail.com>
2010-10-26  3:47         ` Steven Rostedt
     [not found]           ` <AANLkTik5RRYFgBC2oY-9EYWRh7Q72SqhRB4m_2w5Oia4@mail.gmail.com>
2010-10-28 14:03             ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288274585.18238.241.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=graysky@archlinux.us \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®