From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934035Ab0J2QSf (ORCPT ); Fri, 29 Oct 2010 12:18:35 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.123]:37834 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703Ab0J2QSe (ORCPT ); Fri, 29 Oct 2010 12:18:34 -0400 X-Authority-Analysis: v=1.1 cv=kXGwZUU/u1JTMRv8Axk4W0omja+vfTT+sGlOkodD8F8= c=1 sm=0 a=ygIiTo8ZIjQA:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=meVymXHHAAAA:8 a=r09U7IiZZUnzLjUYeeIA:9 a=C3RTsH11_FukJJpf2k_G1XGDYGwA:4 a=PUjeQqilurYA:10 a=jeBq3FmKZ4MA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: [PATCH 2/2] jump label: disable due to compiler bug From: Steven Rostedt To: Mathieu Desnoyers Cc: Ingo Molnar , Jason Baron , David Daney , rth@redhat.com, "H. Peter Anvin" , tglx@linutronix.de, andi@firstfloor.org, roland@redhat.com, masami.hiramatsu.pt@hitachi.com, fweisbec@gmail.com, avi@redhat.com, davem@davemloft.net, vgoyal@redhat.com, sam@ravnborg.org, tony@bakeyournoodle.com, dsd@laptop.org, linux-kernel@vger.kernel.org In-Reply-To: <20101029133524.GA23916@Krystal> References: <2d1b1d5d2b3930e1acb063cefffbcb2faf049854.1288212486.git.jbaron@redhat.com> <20101028141757.GA2875@redhat.com> <4CC9C724.3020004@caviumnetworks.com> <20101028201112.GA4792@redhat.com> <20101029063450.GE29463@elte.hu> <1288354687.18238.433.camel@gandalf.stny.rr.com> <20101029122230.GA25663@elte.hu> <1288356418.18238.454.camel@gandalf.stny.rr.com> <20101029133524.GA23916@Krystal> Content-Type: text/plain; charset="ISO-8859-15" Date: Fri, 29 Oct 2010 12:18:28 -0400 Message-ID: <1288369108.29632.1.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-10-29 at 09:35 -0400, Mathieu Desnoyers wrote: > * Steven Rostedt (rostedt@goodmis.org) wrote: > > Then in the code have: > > > > -#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL) > > +#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_HAVE_ARCH_JUMP_LABEL) \ > > Technically, you could remove the dependency on > "defined(CONFIG_HAVE_ARCH_JUMP_LABEL)", because it is now dealt with at > the Kconfig level (CONFIG_JUMP_LABEL depends on it). Yeah, I noticed that just after hitting send. > > > + && defined(JUMP_LABEL) > > this would be defined(CONFIG_JUMP_LABEL) Yep, this too, but thanks for pointing it out. > > The rest looks fine, Great, can I add your acked-by then? -- Steve