From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758181Ab0J2S0A (ORCPT ); Fri, 29 Oct 2010 14:26:00 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:63141 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516Ab0J2SZ5 (ORCPT ); Fri, 29 Oct 2010 14:25:57 -0400 X-Authority-Analysis: v=1.1 cv=6ptpMFIBtxRk0xdOb6IhJTbTLVRlKjWFes7R4SsWCrA= c=1 sm=0 a=ygIiTo8ZIjQA:10 a=Q9fys5e9bTEA:10 a=OPBmh+XkhLl+Enan7BmTLg==:17 a=mDV3o1hIAAAA:8 a=deMge4z8aYbPzyKb3_sA:9 a=IALjDw_Ie1edGuaJomcA:7 a=UtUYY2bW8OBZo7VcXx98qOIjY14A:4 a=PUjeQqilurYA:10 a=OPBmh+XkhLl+Enan7BmTLg==:117 X-Cloudmark-Score: 0 X-Originating-IP: 67.242.120.143 Subject: Re: [PATCH 2/2] jump label: disable due to compiler bug From: Steven Rostedt To: Richard Henderson Cc: David Daney , Mathieu Desnoyers , Ingo Molnar , Jason Baron , "H. Peter Anvin" , tglx@linutronix.de, andi@firstfloor.org, roland@redhat.com, masami.hiramatsu.pt@hitachi.com, fweisbec@gmail.com, avi@redhat.com, davem@davemloft.net, vgoyal@redhat.com, sam@ravnborg.org, tony@bakeyournoodle.com, dsd@laptop.org, linux-kernel@vger.kernel.org In-Reply-To: <4CCB0EE0.4000401@redhat.com> References: <2d1b1d5d2b3930e1acb063cefffbcb2faf049854.1288212486.git.jbaron@redhat.com> <20101028141757.GA2875@redhat.com> <4CC9C724.3020004@caviumnetworks.com> <20101028201112.GA4792@redhat.com> <20101029063450.GE29463@elte.hu> <1288354687.18238.433.camel@gandalf.stny.rr.com> <20101029122230.GA25663@elte.hu> <1288356418.18238.454.camel@gandalf.stny.rr.com> <20101029133524.GA23916@Krystal> <1288369108.29632.1.camel@gandalf.stny.rr.com> <4CCB01D1.2050004@caviumnetworks.com> <1288373582.29632.3.camel@gandalf.stny.rr.com> <4CCB08EB.8070004@caviumnetworks.com> <4CCB0EE0.4000401@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Date: Fri, 29 Oct 2010 14:25:54 -0400 Message-ID: <1288376754.29632.19.camel@gandalf.stny.rr.com> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2010-10-29 at 11:13 -0700, Richard Henderson wrote: > On 10/29/2010 10:48 AM, David Daney wrote: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226 > > > > Perhaps it could be integrated with the current checks for the presence of 'asm goto' > > If you're looking for a cross-compile-able test, you can strip the > testcase down to > > extern void abort(void); > void g(int x, ...); > void f(int x) > { > if (x == 0) > g(0); > g(1, 2, 3, 4, 5, 6, 7); > asm goto ("XYZZY" : : : : label); > abort (); > label: > return; > } > > and use perl to notice the adjustment to esp before or after XYZZY. > It should be fairly obvious looking at the assembly before and after > the patch. > > I don't know what sort of embedded processors supported by linux > actually use ACCUMULATE_OUTGOING_ARGS. Almost all ports don't, so > I'd be pretty comfortable making this a 32-bit x86 only test, and > let other targets just check that the test compiles. > Thanks! I'll make a patch with this check (for x86_32) and queue it up for 2.6.38. I think we are way past doing this for 2.6.37. -- Steve