Re: [PATCH 1/5] [PATCH 1/5] kconfig: Make localmodconfig handle environment variables

[Steven Rostedt <rostedt@goodmis.org>]

On Fri, 2010-10-29 at 20:26 -0400, Arnaud Lacombe wrote:
> Hi,

> Technically, it is _not_ an environment variable; it is a kconfig
> symbol's name. In this particular case, both name collide and the
> kconfig symbol happens to get its default value from the environment.
> The real fixes, from my point of view, would be to have a perl binding
> of the kconfig backend and get rid of read_kconfig(). That said, your
> patch is broken if a symbol happen not to match an environment
> variable (both in name and value).

That sounds like a proper fix. Unfortunately, I don't have the time to
work on this now, and although this fix works by coincidence, it
never-the-less works, as suppose to just having localmodconfig crash.

But you are right. After KS and Plumbers, I'll work on doing something
like that. That can probably solve some of the other issues I'm having
(still keeping too many modules enabled).

> 
> Btw, two questions:
>  - who has authority on kconfig ? Michal or you ? MAINTAINERS say
> "Roman Zippel", but AFAIK, this is no longer valid.

Michal is in charge of the build system. I just wrote
streamline_config.pl, and have been maintaining it on my own. If I ever
need to touch anything outside of that script, I always ask for Michal's
Acked-by.

>  - what is the delay someone in CC: is given the time to answer a
> patch ? I see that this one particularly is already in Linus' tree.

Well, again, I consider myself the maintainer of streamline_config.pl,
and as long as my changes don't affect anything else, I don't ask for
forgiveness ;-)

I probably should rename my subject (and my git tree) to
s/kconfig/localmodconfig/. But then again, having the kconfig: name gets
the attention of people like yourself to tell me what you told me.

-- Steve