mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, David Vrabel <dvrabel@arcom.com>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Haavard Skinnemoen <hskinnemoen@atmel.com>
Subject: Re: [PATCH 1/7] [AVR32] don't check platform_get_irq's return value against zero
Date: Mon, 01 Nov 2010 10:58:03 +0100	[thread overview]
Message-ID: <1288605483.2843.71.camel@hcegtvedt> (raw)
In-Reply-To: <20101019064543.GA23839@pengutronix.de>

On Tue, 2010-10-19 at 08:45 +0200, Uwe Kleine-König wrote: 
> On Wed, Dec 16, 2009 at 05:10:03PM +0100, Uwe Kleine-König wrote:
> > platform_get_irq returns -ENXIO on failure, so !int_irq was probably
> > always true.  Better use (int)int_irq <= 0.  Note that a return value of
> > zero is still handled as error even though this could mean irq0.

Indeed, but external interrupts are numbered after the internal
interrupt lines, so in practice this does not happen. At least for now
with the AP700X series.

> > This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
> > changed the return value of platform_get_irq from 0 to -ENXIO on error.

Thanks for this fix.

> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Cc: David Vrabel <dvrabel@arcom.com>
> > Cc: Greg Kroah-Hartman <gregkh@suse.de>
> > Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>

Acked-by: Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com>

<snipp>

-- 
Hans-Christian Egtvedt


  reply	other threads:[~2010-11-01 10:05 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 16:10 Uwe Kleine-König
2009-12-16 16:10 ` [PATCH 2/7] V4L/DVB mx1_camera: " Uwe Kleine-König
2009-12-16 16:10   ` [PATCH 3/7] V4L/DVB sh_mobile_ceu: " Uwe Kleine-König
2009-12-16 16:10     ` [PATCH 4/7] can/at91: " Uwe Kleine-König
2009-12-16 16:10       ` [PATCH 5/7] pcmcia/bfin_cf: " Uwe Kleine-König
2009-12-16 16:10         ` [PATCH 6/7] spi/mpc8xxx: " Uwe Kleine-König
2009-12-16 16:10           ` [PATCH 7/7] ASoC: sh: FSI:: " Uwe Kleine-König
2009-12-17  1:42             ` Kuninori Morimoto
2009-12-17  9:47               ` Uwe Kleine-König
2009-12-22 12:34             ` Mark Brown
2009-12-16 16:32           ` [PATCH 6/7] spi/mpc8xxx: " Anton Vorontsov
2009-12-16 17:49             ` Uwe Kleine-König
2009-12-16 18:20               ` Anton Vorontsov
2009-12-16 19:18                 ` Uwe Kleine-König
2009-12-16 19:37                   ` Anton Vorontsov
2009-12-16 19:51                     ` Anton Vorontsov
2009-12-17 13:05                     ` Uwe Kleine-König
2009-12-17 16:25                       ` Anton Vorontsov
2009-12-16 18:20               ` David Vrabel
2009-12-17 16:39           ` Anton Vorontsov
2009-12-19 15:13             ` [PATCH] " Uwe Kleine-König
2009-12-16 16:27       ` [PATCH 4/7] can/at91: " Wolfgang Grandegger
2009-12-16 17:08         ` Uwe Kleine-König
2009-12-16 17:47           ` Alan Cox
2009-12-17  7:17             ` Wolfgang Grandegger
2009-12-16 18:57           ` Wolfgang Grandegger
2009-12-16 18:58       ` Wolfgang Grandegger
2009-12-19  4:32         ` David Miller
2010-01-13 11:05 ` [RESEND PATCH 1/5] [AVR32] " Uwe Kleine-König
2010-01-13 11:05 ` [RESEND PATCH 2/5] V4L/DVB mx1_camera: " Uwe Kleine-König
2010-01-13 11:57   ` platform_get_irq() v4l fixes Guennadi Liakhovetski
2010-01-13 11:05 ` [RESEND PATCH 3/5] V4L/DVB sh_mobile_ceu: don't check platform_get_irq's return value against zero Uwe Kleine-König
2010-01-13 11:05 ` [RESEND PATCH 4/5] pcmcia/bfin_cf: " Uwe Kleine-König
2010-01-13 11:05 ` [RESEND PATCH 5/5] spi/mpc8xxx: " Uwe Kleine-König
2010-01-13 11:17   ` Anton Vorontsov
2010-10-19  6:45 ` [PATCH 1/7] [AVR32] " Uwe Kleine-König
2010-11-01  9:58   ` Hans-Christian Egtvedt [this message]
2010-11-02  9:15     ` Uwe Kleine-König
2010-11-02  9:30       ` Hans-Christian Egtvedt
2011-02-09 10:28         ` [PATCH RESENT#2] " Uwe Kleine-König
2011-02-09 10:43           ` Alan Cox
2011-02-09 12:28           ` Hans-Christian Egtvedt
2011-02-09 12:44             ` Uwe Kleine-König
2011-02-09 12:51               ` Hans-Christian Egtvedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288605483.2843.71.camel@hcegtvedt \
    --to=hans-christian.egtvedt@atmel.com \
    --cc=dvrabel@arcom.com \
    --cc=gregkh@suse.de \
    --cc=hskinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®