mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Christoph Lameter <cl@linux.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
	Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] irq: use per_cpu kstat_irqs
Date: Fri, 05 Nov 2010 18:16:43 +0100	[thread overview]
Message-ID: <1288977403.2882.928.camel@edumazet-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1011051153110.8161@router.home>

Le vendredi 05 novembre 2010 à 11:54 -0500, Christoph Lameter a écrit :
> On Fri, 5 Nov 2010, Eric Dumazet wrote:
> 
> >  static inline void kstat_incr_irqs_this_cpu(unsigned int irq,
> >  					    struct irq_desc *desc)
> 
> desc is not used.
> 
> >  {
> > -	kstat_this_cpu.irqs[irq]++;
> > -	kstat_this_cpu.irqs_sum++;
> > +	__this_cpu_inc(kstat.irqs[irq]);
> > +	__this_cpu_inc(kstat.irqs_sum);
> >  }
> 

Thats right, but it is used in CONFIG_GENERIC_HARDIRQS case.

Prototype of this function is generic, I did not change this.

(I left the macro in CONFIG_GENERIC_HARDIRQS case too because I felt
using a function could break some arches)




      reply	other threads:[~2010-11-05 17:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-04 17:48 [PATCH] " Eric Dumazet
2010-11-04 18:05 ` Christoph Lameter
2010-11-04 18:07   ` Eric Dumazet
2010-11-05  8:27 ` Tejun Heo
2010-11-05 11:19   ` Eric Dumazet
2010-11-05 16:06 ` [PATCH v2] " Eric Dumazet
2010-11-05 16:45   ` Tejun Heo
2010-11-05 16:47     ` Eric Dumazet
2010-11-05 16:54   ` Christoph Lameter
2010-11-05 17:16     ` Eric Dumazet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288977403.2882.928.camel@edumazet-laptop \
    --to=eric.dumazet@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=cl@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®