mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Jiri Kosina <trivial@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/7] arch/x86/kernel/pci-iommu_table.c: Convert sprintf_symbol to %pS
Date: Fri,  5 Nov 2010 16:12:35 -0700	[thread overview]
Message-ID: <1288998760-11775-3-git-send-email-joe@perches.com> (raw)
In-Reply-To: <1288998760-11775-1-git-send-email-joe@perches.com>

Coalesce format as well.

Signed-off-by: Joe Perches <joe@perches.com>
---
 arch/x86/kernel/pci-iommu_table.c |   18 ++++--------------
 1 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/arch/x86/kernel/pci-iommu_table.c b/arch/x86/kernel/pci-iommu_table.c
index 55d745e..35ccf75 100644
--- a/arch/x86/kernel/pci-iommu_table.c
+++ b/arch/x86/kernel/pci-iommu_table.c
@@ -50,20 +50,14 @@ void __init check_iommu_entries(struct iommu_table_entry *start,
 				struct iommu_table_entry *finish)
 {
 	struct iommu_table_entry *p, *q, *x;
-	char sym_p[KSYM_SYMBOL_LEN];
-	char sym_q[KSYM_SYMBOL_LEN];
 
 	/* Simple cyclic dependency checker. */
 	for (p = start; p < finish; p++) {
 		q = find_dependents_of(start, finish, p);
 		x = find_dependents_of(start, finish, q);
 		if (p == x) {
-			sprint_symbol(sym_p, (unsigned long)p->detect);
-			sprint_symbol(sym_q, (unsigned long)q->detect);
-
-			printk(KERN_ERR "CYCLIC DEPENDENCY FOUND! %s depends" \
-					" on %s and vice-versa. BREAKING IT.\n",
-					sym_p, sym_q);
+			printk(KERN_ERR "CYCLIC DEPENDENCY FOUND! %pS depends on %pS and vice-versa. BREAKING IT.\n",
+			       p->detect, q->detect);
 			/* Heavy handed way..*/
 			x->depend = 0;
 		}
@@ -72,12 +66,8 @@ void __init check_iommu_entries(struct iommu_table_entry *start,
 	for (p = start; p < finish; p++) {
 		q = find_dependents_of(p, finish, p);
 		if (q && q > p) {
-			sprint_symbol(sym_p, (unsigned long)p->detect);
-			sprint_symbol(sym_q, (unsigned long)q->detect);
-
-			printk(KERN_ERR "EXECUTION ORDER INVALID! %s "\
-					"should be called before %s!\n",
-					sym_p, sym_q);
+			printk(KERN_ERR "EXECUTION ORDER INVALID! %pS should be called before %pS!\n",
+			       p->detect, q->detect);
 		}
 	}
 }
-- 
1.7.3.2.146.gca209


  parent reply	other threads:[~2010-11-05 23:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-05 23:12 [PATCH 0/7] Convert sprintf_symbol uses to %p[Ss] Joe Perches
2010-11-05 23:12 ` [PATCH 1/7] arch/arm/kernel/traps.c: Convert sprintf_symbol to %pS Joe Perches
2010-11-05 23:12 ` Joe Perches [this message]
2010-11-10 15:48   ` [PATCH 2/7] arch/x86/kernel/pci-iommu_table.c: " Joerg Roedel
2010-11-05 23:12 ` [PATCH 3/7] fs/gfs2/glock.c: " Joe Perches
2010-11-08 10:26   ` Steven Whitehouse
2010-11-05 23:12 ` [PATCH 4/7] fs/proc/base.c kernel/latencytop.c: Convert sprintf_symbol to %ps Joe Perches
2010-11-05 23:12 ` [PATCH 5/7] kernel/lockdep_proc.c: Convert sprintf_symbol to %pS Joe Perches
2010-11-05 23:12 ` [PATCH 6/7] mm: " Joe Perches
2010-11-06 15:00   ` Pekka Enberg
2010-11-05 23:12 ` [PATCH 7/7] net/sunrpc/clnt.c: Convert sprintf_symbol to %ps Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1288998760-11775-3-git-send-email-joe@perches.com \
    --to=joe@perches.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=trivial@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome