From: Steven Rostedt <rostedt@goodmis.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
linux-kernel@vger.kernel.org,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] Tracing: do export trace_set_clr_event
Date: Mon, 08 Nov 2010 09:23:04 -0500 [thread overview]
Message-ID: <1289226184.12418.4.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20101108141420.GA12548@infradead.org>
On Mon, 2010-11-08 at 09:14 -0500, Christoph Hellwig wrote:
> On Mon, Nov 08, 2010 at 09:02:14AM -0500, Steven Rostedt wrote:
> > I like the trace=on parameter much better. If that is set we could
> > enable the tracepoints of that module at load time. I really do not want
> > to export the function that was proposed in that patch.
>
> Yes. Adding generic support in the module loader to turn on tracepoint
> seems like the much better long term strategy. Even better if it allows
> turning on individual points instead of all or nothing.
I was thinking the same. How about this:
trace=1 - all tracepoints in the module is enabled
trace=0 - same as leaving it off
trace=name - a specific tracepoint is enabled, using the simple globs
that set_event allows.
trace=name1,name2,name3 - for more than one tracepoint.
-- Steve
next prev parent reply other threads:[~2010-11-08 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-08 6:05 Yuanhan Liu
2010-11-08 9:56 ` Christoph Hellwig
2010-11-08 10:14 ` Chris Wilson
2010-11-08 14:02 ` Steven Rostedt
2010-11-08 14:14 ` Christoph Hellwig
2010-11-08 14:23 ` Steven Rostedt [this message]
2010-11-09 1:44 ` Yuanhan Liu
2011-03-11 9:52 ` [tip:perf/core] tracing: Export trace_set_clr_event() tip-bot for Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289226184.12418.4.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=chris@chris-wilson.co.uk \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®